chrome/browser/sync/glue/favicon_cache.cc - Issue 331163003: [Refactor] Change FaviconService API to take in a desired pixel size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/favicon_cache.cc

Issue 331163003: [Refactor] Change FaviconService API to take in a desired pixel size (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/favicon_cache.cc

diff --git a/chrome/browser/sync/glue/favicon_cache.cc b/chrome/browser/sync/glue/favicon_cache.cc

index 82b9a85a127c5d309a5f792cad611939e27fb6cf..ecd7e1d338ab6e0e31dc2e56a3684b39e7671fe2 100644

--- a/chrome/browser/sync/glue/favicon_cache.cc

+++ b/chrome/browser/sync/glue/favicon_cache.cc

@@ -443,8 +443,9 @@ void FaviconCache::OnPageFaviconUpdated(const GURL& page_url) {

// See crbug.com/181068.

base::CancelableTaskTracker::TaskId id =

favicon_service->GetFaviconForPageURL(

- FaviconService::FaviconForPageURLParams(

- page_url, SupportedFaviconTypes(), kMaxFaviconResolution),

+ page_url,

+ SupportedFaviconTypes(),

+ kMaxFaviconResolution,

base::Bind(&FaviconCache::OnFaviconDataAvailable,

weak_ptr_factory_.GetWeakPtr(),

page_url),