chrome/browser/favicon/favicon_handler.cc - Issue 331163003: [Refactor] Change FaviconService API to take in a desired pixel size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_handler.cc

Issue 331163003: [Refactor] Change FaviconService API to take in a desired pixel size (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_handler.cc

diff --git a/chrome/browser/favicon/favicon_handler.cc b/chrome/browser/favicon/favicon_handler.cc

index 18fa44704ed7c5e379129932e3d9b5c1adec1e2d..fe2e2123b84733ccd1cff0c25545b4b9b0aff272 100644

--- a/chrome/browser/favicon/favicon_handler.cc

+++ b/chrome/browser/favicon/favicon_handler.cc

@@ -509,8 +509,9 @@ void FaviconHandler::GetFaviconForURLFromFaviconService(

const favicon_base::FaviconResultsCallback& callback,

base::CancelableTaskTracker* tracker) {

client_->GetFaviconService()->GetFaviconForPageURL(

- FaviconService::FaviconForPageURLParams(

- page_url, icon_types, preferred_icon_size()),

+ page_url,

+ icon_types,

+ preferred_icon_size(),

callback,

tracker);

}