Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 331163003: [Refactor] Change FaviconService API to take in a desired pixel size (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/bookmarks/chrome_bookmark_client.cc ('k') | chrome/browser/favicon/favicon_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/management/management_api.cc
diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc
index 3e606854efffa583278c28ddb6b78fb2e42bc0f2..a23288f54367e9e85692a3951bdb0271ca9ccdee 100644
--- a/chrome/browser/extensions/api/management/management_api.cc
+++ b/chrome/browser/extensions/api/management/management_api.cc
@@ -53,7 +53,6 @@
#include "extensions/common/permissions/permission_set.h"
#include "extensions/common/permissions/permissions_data.h"
#include "extensions/common/url_pattern.h"
-#include "ui/gfx/favicon_size.h"
using base::IntToString;
using content::BrowserThread;
@@ -915,8 +914,7 @@ bool ManagementGenerateAppForLinkFunction::RunAsync() {
launch_url_ = launch_url;
favicon_service->GetFaviconImageForPageURL(
- FaviconService::FaviconForPageURLParams(
- launch_url, favicon_base::FAVICON, gfx::kFaviconSize),
+ launch_url,
base::Bind(&ManagementGenerateAppForLinkFunction::OnFaviconForApp, this),
&cancelable_task_tracker_);
« no previous file with comments | « chrome/browser/bookmarks/chrome_bookmark_client.cc ('k') | chrome/browser/favicon/favicon_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698