Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 331143007: Remove the LOG_ERROR_REPORT log severity level. (Closed)

Created:
6 years, 6 months ago by viettrungluu
Modified:
6 years, 6 months ago
Reviewers:
brettw, sky
CC:
chromium-reviews, stgao, erikwright+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove the LOG_ERROR_REPORT log severity level. It's been unused since r255987 (which removed the --enable-dcheck flag, among other things). Also remove the --silent-dump-on-dcheck flag (because now there's not even code that pretends to use it). R=brettw@chromium.org,sky@chromium.org BUG=352378 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277736

Patch Set 1 #

Patch Set 2 : missed a SetLogReportHandler; also removed the --silent-dump-on-dcheck flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -94 lines) Patch
M base/logging.h View 6 chunks +8 lines, -27 lines 0 comments Download
M base/logging.cc View 8 chunks +4 lines, -17 lines 0 comments Download
M base/logging_unittest.cc View 4 chunks +1 line, -23 lines 0 comments Download
M base/logging_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/logging_chrome.cc View 1 3 chunks +0 lines, -15 lines 0 comments Download
M chrome/test/chromedriver/logging.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/logging/win/log_file_printer.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
brettw -> review (mostly base/) sky -> chrome/ OWNERS
6 years, 6 months ago (2014-06-16 20:07:26 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-16 20:11:13 UTC) #2
brettw
lgtm
6 years, 6 months ago (2014-06-16 20:21:04 UTC) #3
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 6 months ago (2014-06-17 06:08:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/331143007/20001
6 years, 6 months ago (2014-06-17 06:08:48 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 12:04:29 UTC) #6
Message was sent while issue was closed.
Change committed as 277736

Powered by Google App Engine
This is Rietveld 408576698