Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4517)

Unified Diff: chrome/common/logging_chrome.cc

Issue 331143007: Remove the LOG_ERROR_REPORT log severity level. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: missed a SetLogReportHandler; also removed the --silent-dump-on-dcheck flag Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | chrome/test/chromedriver/logging.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/logging_chrome.cc
diff --git a/chrome/common/logging_chrome.cc b/chrome/common/logging_chrome.cc
index 7398a897e747a9505739ad0a37b5f3b562bce2fc..adca73734a85772e04cc5cd6dc42f707e51a4fa9 100644
--- a/chrome/common/logging_chrome.cc
+++ b/chrome/common/logging_chrome.cc
@@ -90,15 +90,6 @@ MSVC_DISABLE_OPTIMIZE();
void SilentRuntimeAssertHandler(const std::string& str) {
base::debug::BreakDebugger();
}
-void SilentRuntimeReportHandler(const std::string& str) {
-}
-#if defined(OS_WIN)
-// Handler to silently dump the current process when there is an assert in
-// chrome.
-void DumpProcessAssertHandler(const std::string& str) {
- base::debug::DumpWithoutCrashing();
-}
-#endif // OS_WIN
MSVC_ENABLE_OPTIMIZE();
// Suppresses error/assertion dialogs and enables the logging of
@@ -108,7 +99,6 @@ void SuppressDialogs() {
return;
logging::SetLogAssertHandler(SilentRuntimeAssertHandler);
- logging::SetLogReportHandler(SilentRuntimeReportHandler);
#if defined(OS_WIN)
UINT new_flags = SEM_FAILCRITICALERRORS |
@@ -358,11 +348,6 @@ void InitChromeLogging(const CommandLine& command_line,
logging::LogEventProvider::Initialize(kChromeTraceProviderName);
#endif
-#if DCHECK_IS_ON && defined(NDEBUG) && defined(OS_WIN)
- if (command_line.HasSwitch(switches::kSilentDumpOnDCHECK))
- logging::SetLogReportHandler(DumpProcessAssertHandler);
-#endif
-
chrome_logging_initialized_ = true;
}
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | chrome/test/chromedriver/logging.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698