QUIC Crypto - return the reasons for reject message. Reject reason

net/quic/crypto/quic_crypto_client_config.cc

Index: net/quic/crypto/quic_crypto_client_config.cc
diff --git a/net/quic/crypto/quic_crypto_client_config.cc b/net/quic/crypto/quic_crypto_client_config.cc
index 8dc6a55445727ba66938f43f6306bb4dd4234ad2..8f4097be188977ba8cb38f30f19299ee59940503 100644
--- a/net/quic/crypto/quic_crypto_client_config.cc
+++ b/net/quic/crypto/quic_crypto_client_config.cc
@@ -587,6 +587,17 @@ QuicErrorCode QuicCryptoClientConfig::ProcessRejection(
     }
   }
 
+  const QuicTag* reject_reason_tags;

[wtc, 2014/06/19 00:13:24]

Nit: name this variable |reject_reasons| because strictly speaking they are not
QuicTags.

[ramant (doing other things), 2014/06/19 01:57:34]

Done.

+  size_t num_reject_reasons;
+  if (rej.GetTaglist(kRejectReason, &reject_reason_tags,
+                     &num_reject_reasons) == QUIC_NO_ERROR) {
+#ifndef NDEBUG

[wtc, 2014/06/19 00:13:24]

Nit: use
  #if defined(DEBUG)
or
  #if !defined(NDEBUG)

Chromium's local style recommends against #ifdef and #ifndef. If QUIC's local
style prefers #ifdef and #ifndef, then this is fine.

[ramant (doing other things), 2014/06/19 01:57:34]

Done.

+    for (size_t i = 0; i < num_reject_reasons; ++i) {
+      DVLOG(1) << "Reason for rejection: " << reject_reason_tags[i];

[wtc, 2014/06/19 00:13:24]

Nit: Reason => Reasons

[ramant (doing other things), 2014/06/19 01:57:34]

Done.

+    }
+#endif
+  }
+
   return QUIC_NO_ERROR;
 }