QUIC Crypto - return the reasons for reject message. Reject reason

net/quic/crypto/quic_crypto_client_config.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/crypto/quic_crypto_client_config.h"
 
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
 #include "net/quic/crypto/cert_compressor.h"
 #include "net/quic/crypto/chacha20_poly1305_encrypter.h"
@@ skipping 569 matching lines @@
       *error_details = "Certificate missing";
       return QUIC_INVALID_CRYPTO_MESSAGE_PARAMETER;
     }
 
     if (!has_proof && has_cert) {
       *error_details = "Proof missing";
       return QUIC_INVALID_CRYPTO_MESSAGE_PARAMETER;
     }
   }
 
+  const QuicTag* reject_reason_tags;

[wtc, 2014/06/19 00:13:24]

Nit: name this variable |reject_reasons| because strictly speaking they are not
QuicTags.

[ramant (doing other things), 2014/06/19 01:57:34]

Done.

+  size_t num_reject_reasons;
+  if (rej.GetTaglist(kRejectReason, &reject_reason_tags,
+                     &num_reject_reasons) == QUIC_NO_ERROR) {
+#ifndef NDEBUG

[wtc, 2014/06/19 00:13:24]

Nit: use
  #if defined(DEBUG)
or
  #if !defined(NDEBUG)

Chromium's local style recommends against #ifdef and #ifndef. If QUIC's local
style prefers #ifdef and #ifndef, then this is fine.

[ramant (doing other things), 2014/06/19 01:57:34]

Done.

+    for (size_t i = 0; i < num_reject_reasons; ++i) {
+      DVLOG(1) << "Reason for rejection: " << reject_reason_tags[i];

[wtc, 2014/06/19 00:13:24]

Nit: Reason => Reasons

[ramant (doing other things), 2014/06/19 01:57:34]

Done.

+    }
+#endif
+  }
+
   return QUIC_NO_ERROR;
 }
 
 QuicErrorCode QuicCryptoClientConfig::ProcessServerHello(
     const CryptoHandshakeMessage& server_hello,
     QuicConnectionId connection_id,
     const QuicVersionVector& negotiated_versions,
     CachedState* cached,
     QuicCryptoNegotiatedParameters* out_params,
     string* error_details) {
@@ skipping 144 matching lines @@
     return;
   }
 
   // Update canonical version to point at the "most recent" entry.
   canonical_server_map_[suffix_server_id] = server_id;
 
   server_state->InitializeFrom(*canonical_state);
 }
 
 }  // namespace net