Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 331143005: DevTools: Add showing viewport for Layers3DView. (Closed)

Created:
6 years, 6 months ago by malch
Modified:
6 years, 6 months ago
Reviewers:
caseq
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixes. #

Patch Set 3 : Fixed test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -10 lines) Patch
M LayoutTests/inspector/layers/layers-3d-view-hit-testing.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sdk/LayerTreeModel.js View 1 3 chunks +20 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/Layers3DView.js View 1 4 chunks +19 lines, -6 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineFrameModel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineTracingView.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
malch
Please take a look
6 years, 6 months ago (2014-06-16 16:04:58 UTC) #1
caseq
lgtm https://codereview.chromium.org/331143005/diff/1/Source/devtools/front_end/sdk/LayerTreeModel.js File Source/devtools/front_end/sdk/LayerTreeModel.js (right): https://codereview.chromium.org/331143005/diff/1/Source/devtools/front_end/sdk/LayerTreeModel.js#newcode1154 Source/devtools/front_end/sdk/LayerTreeModel.js:1154: result.setViewportSize(this._viewportSize); I'd rather have it set before layers, ...
6 years, 6 months ago (2014-06-16 16:11:06 UTC) #2
malch
https://codereview.chromium.org/331143005/diff/1/Source/devtools/front_end/sdk/LayerTreeModel.js File Source/devtools/front_end/sdk/LayerTreeModel.js (right): https://codereview.chromium.org/331143005/diff/1/Source/devtools/front_end/sdk/LayerTreeModel.js#newcode1154 Source/devtools/front_end/sdk/LayerTreeModel.js:1154: result.setViewportSize(this._viewportSize); On 2014/06/16 16:11:06, caseq wrote: > I'd rather ...
6 years, 6 months ago (2014-06-16 16:16:14 UTC) #3
caseq
lgtm
6 years, 6 months ago (2014-06-16 16:16:50 UTC) #4
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-16 16:16:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/malch@chromium.org/331143005/20001
6 years, 6 months ago (2014-06-16 16:17:52 UTC) #6
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-16 17:07:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/malch@chromium.org/331143005/40001
6 years, 6 months ago (2014-06-16 17:08:09 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 18:12:15 UTC) #9
Message was sent while issue was closed. 
Change committed as 176229

Powered by Google App Engine
This is Rietveld 408576698