Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 331133002: Default to malware interstitial v3 (Closed)

Created:
6 years, 6 months ago by felt
Modified:
6 years, 6 months ago
Reviewers:
mattm
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Default to malware interstitial v3 Changes Version3Enabled for the malware interstitial. Default is now v3 unless a flag or field trial say otherwise. BUG=381260 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278021

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Remove unused variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 2 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
felt
Please take a look. I plan to land this after 339503004 (the reporting checkbox) and ...
6 years, 6 months ago (2014-06-16 05:59:21 UTC) #1
mattm
lgtm
6 years, 6 months ago (2014-06-17 18:49:45 UTC) #2
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-17 19:00:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/331133002/1
6 years, 6 months ago (2014-06-17 19:03:08 UTC) #4
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-17 21:29:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/331133002/20001
6 years, 6 months ago (2014-06-17 21:29:41 UTC) #6
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-17 22:58:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/331133002/40001
6 years, 6 months ago (2014-06-17 22:59:21 UTC) #8
felt
The CQ bit was unchecked by felt@chromium.org
6 years, 6 months ago (2014-06-18 05:09:26 UTC) #9
felt
The CQ bit was checked by felt@chromium.org
6 years, 6 months ago (2014-06-18 05:09:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/331133002/40001
6 years, 6 months ago (2014-06-18 05:10:29 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 10:40:14 UTC) #12
Message was sent while issue was closed.
Change committed as 278021

Powered by Google App Engine
This is Rietveld 408576698