Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 331133002: Default to malware interstitial v3 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unused variable Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
index 458d142e26044663e1f38e681fc01ef9d938b5d7..97db33b26d54d844ba7799da3fb55d8318ca22bc 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
@@ -150,12 +150,19 @@ void RecordDetailedUserAction(DetailedDecision decision) {
MAX_DETAILED_ACTION);
}
+// These are the constants for the M37 Finch trial.
+const char kV3StudyName[] = "MalwareInterstitialVersion";
+const char kCondUseV2[] = "V2";
+
+// Default to V3 unless a flag or field trial says otherwise.
bool Version3Enabled() {
if (CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kMalwareInterstitialVersionV3)) {
- return true;
+ switches::kMalwareInterstitialVersionV2)) {
+ return false;
}
- return false;
+ if (base::FieldTrialList::FindFullName(kV3StudyName) == kCondUseV2)
+ return false;
+ return true;
}
} // namespace
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698