Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 331123003: Revert 277208 "[PPAPI] Compositor API implementation." (Closed)

Created:
6 years, 6 months ago by tzik
Modified:
6 years, 6 months ago
Reviewers:
Peng
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Revert 277208 "[PPAPI] Compositor API implementation." This CL seems to cause perf bot failure. The log said nacl_helper-data size gained exceeds expectation. http://build.chromium.org/p/chromium/builders/Linux/builds/50560 https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fnacl_helper-data&rev=277212&checked=core > [PPAPI] Compositor API implementation. > > Implement the compositor API which allows a plugin to combine different sources of visual data efficiently, such as PPB_ImageData and OpengGL texture. > > API Proposal http://goo.gl/V7xcu3 > > BUG=374383 > > Review URL: https://codereview.chromium.org/298023004 TBR=penghuang@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277372

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2300 lines) Patch
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/pepper/content_renderer_pepper_host_factory.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/pepper/gfx_conversion.h View 2 chunks +0 lines, -5 lines 0 comments Download
D content/renderer/pepper/pepper_compositor_host.h View 1 chunk +0 lines, -101 lines 0 comments Download
D content/renderer/pepper/pepper_compositor_host.cc View 1 chunk +0 lines, -372 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.h View 4 chunks +1 line, -5 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 11 chunks +16 lines, -55 lines 0 comments Download
D ppapi/examples/compositor/compositor.cc View 1 chunk +0 lines, -439 lines 0 comments Download
D ppapi/examples/compositor/compositor.html View 1 chunk +0 lines, -28 lines 0 comments Download
D ppapi/examples/compositor/spinning_cube.h View 1 chunk +0 lines, -42 lines 0 comments Download
D ppapi/examples/compositor/spinning_cube.cc View 1 chunk +0 lines, -459 lines 0 comments Download
M ppapi/host/resource_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/host/resource_host.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/ppapi_internal.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 chunk +0 lines, -16 lines 0 comments Download
M ppapi/proxy/compositor_layer_resource.h View 3 chunks +3 lines, -45 lines 0 comments Download
M ppapi/proxy/compositor_layer_resource.cc View 2 chunks +14 lines, -317 lines 0 comments Download
M ppapi/proxy/compositor_resource.h View 2 chunks +1 line, -44 lines 0 comments Download
M ppapi/proxy/compositor_resource.cc View 1 chunk +4 lines, -103 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 6 chunks +0 lines, -59 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.h View 2 chunks +0 lines, -9 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 3 chunks +1 line, -4 lines 0 comments Download
D ppapi/shared_impl/compositor_layer_data.h View 1 chunk +0 lines, -119 lines 0 comments Download
D ppapi/shared_impl/compositor_layer_data.cc View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tzik
PTL later. I think you can just reland the CL and update the size expectation.
6 years, 6 months ago (2014-06-16 07:17:18 UTC) #1
tzik
Committed patchset #1 manually as r277372 (presubmit successful).
6 years, 6 months ago (2014-06-16 07:21:37 UTC) #2
Peng
On 2014/06/16 07:17:18, tzik wrote: > PTL later. > > I think you can just ...
6 years, 6 months ago (2014-06-16 12:20:44 UTC) #3
tzik
6 years, 6 months ago (2014-06-17 06:22:10 UTC) #4
Message was sent while issue was closed.
On 2014/06/16 12:20:44, Peng wrote:
> On 2014/06/16 07:17:18, tzik wrote:
> > PTL later.
> > 
> > I think you can just reland the CL and update the size expectation.
> 
> How do I update the size expectation? Or just reland the CL?

Sorry for late follow up.
The instruction is available on "Handle sizes regressions" in
http://www.chromium.org/developers/tree-sheriffs/perf-sheriffs

For your case, (1) reland your CL, (2) update "reva" and "revb" in
tools/perf_expectations/perf_expectations.json, (3) run make_expectations.py,
(4) upload, get reviewed and land the expectation update.

Powered by Google App Engine
This is Rietveld 408576698