Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1801)

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 330953002: Add accessibility settings metrics (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/browser_options.js
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index c5fd816d04aa3b2ab4c2fbad9fefd0501d113a92..768c50376006b2a3397f3e9c458b9c3113e627ab 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -496,6 +496,11 @@ cr.define('options', function() {
Preferences.getInstance().addEventListener(
'settings.accessibility',
updateAccessibilitySettingsButton);
+ $('accessibility-learn-more').onclick = function(event) {
michaelpg 2014/06/13 22:05:05 nit-ish: unused parameter
stevenjb 2014/06/13 22:11:01 Hmm, pattern elsewhere seems to be to include the
Dan Beam 2014/06/16 19:08:24 personal preference: no unused params Super Offici
stevenjb 2014/06/16 21:06:16 I discussed this with some Blink developers and we
+ window.open(loadTimeData.getString('accessibilityLearnMoreURL'));
+ chrome.send('coreOptionsUserMetricsAction',
+ ['Options_AccessibilityLearnMore']);
+ };
$('accessibility-settings-button').onclick = function(event) {
window.open(loadTimeData.getString('accessibilitySettingsURL'));
};

Powered by Google App Engine
This is Rietveld 408576698