Add accessibility settings metrics

chrome/browser/resources/options/browser_options.html

Index: chrome/browser/resources/options/browser_options.html
diff --git a/chrome/browser/resources/options/browser_options.html b/chrome/browser/resources/options/browser_options.html
index 83ac8f56259bd4b48b1e388c2ff9ebb49384307d..a27b05d5384286b439948b86804bf7733e90846a 100644
--- a/chrome/browser/resources/options/browser_options.html
+++ b/chrome/browser/resources/options/browser_options.html
@@ -686,7 +686,7 @@
           <input id="local-discovery-notifications-enabled"
                  pref="local_discovery.notifications_enabled"
                  type="checkbox"
-                 metric="LocalDiscoveryNotificationsDisabled_Settings" />
+                 metric="LocalDiscoveryNotificationsDisabled_Settings">
           <span>
             <label for="local-discovery-notifications-enabled"
                    i18n-content="cloudPrintEnableNotificationsLabel">
@@ -707,14 +707,15 @@
     <div class="option-control-table">
       <p id="accessibility-explanation" class="settings-row">
         <span i18n-content="accessibilityExplanation"></span>
-        <a target="_blank" i18n-content="learnMore"
-            i18n-values="href:accessibilityLearnMoreURL"></a>
+        <a id="accessibility-learn-more" target="_blank"
+           i18n-content="learnMore"></a>
       </p>
       <div class="option-name">
         <div class="checkbox">
           <span class="controlled-setting-with-label">
             <input id="accessibility-should-always-show-menu"
-                pref="settings.a11y.enable_menu" type="checkbox">
+                   pref="settings.a11y.enable_menu" type="checkbox"
+                   metric="Options_AccessibilitySystemMenu">

[Dan Beam, 2014/06/16 19:08:24]

^ I assume these are already in the metrics system somehow?

[stevenjb, 2014/06/16 21:06:16]

Doh. I missed the actions.xml changes on both these CLs. Will fix, thanks.

             <span>
               <label for="accessibility-should-always-show-menu"
                   i18n-content="accessibilityAlwaysShowMenu">
@@ -729,7 +730,8 @@
         <div class="checkbox">
           <span class="controlled-setting-with-label">
             <input id="accessibility-large-cursor-check"
-                pref="settings.a11y.large_cursor_enabled" type="checkbox">
+                   pref="settings.a11y.large_cursor_enabled" type="checkbox"
+                   metric="Options_AccessibilityLargeMouseCursor">
             <span>
               <label for="accessibility-large-cursor-check"
                   i18n-content="accessibilityLargeCursor">
@@ -745,7 +747,8 @@
         <div class="checkbox">
           <span class="controlled-setting-with-label">
             <input id="accessibility-high-contrast-check"
-                pref="settings.a11y.high_contrast_enabled" type="checkbox">
+                   pref="settings.a11y.high_contrast_enabled" type="checkbox"
+                   metric="Options_AccessibilityHighContrastMode">
             <span>
               <label for="accessibility-high-contrast-check"
                   i18n-content="accessibilityHighContrast">
@@ -761,7 +764,8 @@
         <div class="checkbox">
           <span class="controlled-setting-with-label">
             <input id="accessibility-sticky-keys-check"
-                pref="settings.a11y.sticky_keys_enabled" type="checkbox">
+                   pref="settings.a11y.sticky_keys_enabled" type="checkbox"
+                   metric="Options_AccessibilityStickyKeys">
             <span>
               <label for="accessibility-sticky-keys-check"
                   i18n-content="accessibilityStickyKeys">
@@ -777,7 +781,8 @@
         <div class="checkbox">
           <span class="controlled-setting-with-label">
             <input id="accessibility-spoken-feedback-check"
-                pref="settings.accessibility" type="checkbox">
+                   pref="settings.accessibility" type="checkbox"
+                   metric="Options_AccessibilitySpokenFeedback">
             <span>
               <label for="accessibility-spoken-feedback-check"
                   i18n-content="accessibilitySpokenFeedback">
@@ -797,7 +802,8 @@
         <div class="checkbox">
           <span class="controlled-setting-with-label">
             <input id="accessibility-screen-magnifier-check"
-                pref="settings.a11y.screen_magnifier" type="checkbox">
+                   pref="settings.a11y.screen_magnifier" type="checkbox"
+                   metric="Options_AccessibilityScreenMagnifier">
             <span>
               <label for="accessibility-screen-magnifier-check"
                   i18n-content="accessibilityScreenMagnifier">
@@ -813,7 +819,8 @@
         <div class="checkbox">
           <label>
             <input id="accessibility-tap-dragging-check"
-                pref="settings.touchpad.enable_tap_dragging" type="checkbox">
+                   pref="settings.touchpad.enable_tap_dragging" type="checkbox"
+                   metric="Options_AccessibilityTapDragging">
             <span i18n-content="accessibilityTapDragging"></span>
           </label>
         </div>
@@ -862,7 +869,8 @@
         <div class="checkbox">
           <span class="controlled-setting-with-label">
             <input id="accessibility-virtual-keyboard-check"
-                pref="settings.a11y.virtual_keyboard" type="checkbox">
+                   pref="settings.a11y.virtual_keyboard" type="checkbox"
+                   metric="Options_AccessibilityOnScreenKeyboard">
             <span>
               <label for="accessibility-virtual-keyboard-check"
                   i18n-content="accessibilityVirtualKeyboard">