Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 330943002: remove all references to weightedDiffMeasure from cluster_telemetry code (Closed)

Created:
6 years, 6 months ago by epoger
Modified:
6 years, 6 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot.git@master
Visibility:
Public.

Description

remove all references to weightedDiffMeasure from cluster_telemetry code to handle https://codereview.chromium.org/334533003/ ('rebaseline_server: delete no-longer-used weightedDiffMeasure') Committed: https://skia.googlesource.com/buildbot/+/d2c20ad6d1713bea9a946100c85b292cabefc28b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -80 lines) Patch
M cluster_telemetry/json_summary_constants.py View 1 chunk +0 lines, -1 line 0 comments Download
M cluster_telemetry/telemetry_master_scripts/html-templates/list_of_all_files.html View 1 chunk +1 line, -1 line 1 comment Download
M cluster_telemetry/telemetry_master_scripts/html-templates/single_file_details.html View 2 chunks +1 line, -2 lines 1 comment Download
M cluster_telemetry/telemetry_master_scripts/json_summary_combiner.py View 3 chunks +1 line, -5 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/json_summary_combiner_test.py View 5 chunks +7 lines, -10 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/differences/summary1.json View 2 chunks +0 lines, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/differences/summary2.json View 2 chunks +0 lines, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/differences/summary3.json View 2 chunks +0 lines, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/differences/summary4.json View 2 chunks +0 lines, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/differences/summary5.json View 2 chunks +0 lines, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/html_outputs/differences_no_url/fileslave1_1.png.html View 2 chunks +1 line, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/html_outputs/differences_no_url/fileslave1_2.png.html View 2 chunks +1 line, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/html_outputs/differences_no_url/fileslave2_1.png.html View 2 chunks +1 line, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/html_outputs/differences_no_url/fileslave3_1.png.html View 2 chunks +1 line, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/html_outputs/differences_no_url/fileslave3_2.png.html View 2 chunks +1 line, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/html_outputs/differences_no_url/fileslave3_3.png.html View 2 chunks +1 line, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/html_outputs/differences_no_url/fileslave3_4.png.html View 2 chunks +1 line, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/html_outputs/differences_no_url/list_of_all_files.html View 7 chunks +7 lines, -7 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/html_outputs/differences_with_url/fileslave1_1.png.html View 2 chunks +1 line, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/html_outputs/differences_with_url/fileslave1_2.png.html View 2 chunks +1 line, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/html_outputs/differences_with_url/fileslave2_1.png.html View 2 chunks +1 line, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/html_outputs/differences_with_url/fileslave3_1.png.html View 2 chunks +1 line, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/html_outputs/differences_with_url/fileslave3_2.png.html View 2 chunks +1 line, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/html_outputs/differences_with_url/fileslave3_3.png.html View 2 chunks +1 line, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/html_outputs/differences_with_url/fileslave3_4.png.html View 2 chunks +1 line, -2 lines 0 comments Download
M cluster_telemetry/telemetry_master_scripts/test_data/combiner/html_outputs/differences_with_url/list_of_all_files.html View 7 chunks +7 lines, -7 lines 0 comments Download
M cluster_telemetry/telemetry_slave_scripts/mocks/imagediffdb.py View 1 chunk +0 lines, -3 lines 0 comments Download
M cluster_telemetry/telemetry_slave_scripts/test_data/summary.json View 2 chunks +2 lines, -4 lines 0 comments Download
M cluster_telemetry/telemetry_slave_scripts/write_json_summary.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
epoger
Ravi- PTAL, adjust as you like, and commit in my absence. Sorry for the surprise ...
6 years, 6 months ago (2014-06-13 21:16:57 UTC) #1
rmistry
This CL LGTM, I also like your changes to the template. I will send this ...
6 years, 6 months ago (2014-06-16 11:54:24 UTC) #2
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 6 months ago (2014-06-16 11:54:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/330943002/1
6 years, 6 months ago (2014-06-16 11:55:20 UTC) #4
commit-bot: I haz the power
Change committed as d2c20ad6d1713bea9a946100c85b292cabefc28b
6 years, 6 months ago (2014-06-16 11:55:38 UTC) #5
rmistry
6 years, 6 months ago (2014-06-16 13:29:46 UTC) #6
Message was sent while issue was closed.
On 2014/06/16 11:55:38, I haz the power (commit-bot) wrote:
> Change committed as d2c20ad6d1713bea9a946100c85b292cabefc28b

Looks like this worked first attempt:
https://storage.cloud.google.com/chromium-skia-gm/telemetry/skia-tryserver/ht...

Thanks for fixing this!

Powered by Google App Engine
This is Rietveld 408576698