cluster_telemetry/telemetry_master_scripts/json_summary_combiner.py - Issue 330943002: remove all references to weightedDiffMeasure from cluster_telemetry code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cluster_telemetry/telemetry_master_scripts/json_summary_combiner.py

Issue 330943002: remove all references to weightedDiffMeasure from cluster_telemetry code (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cluster_telemetry/telemetry_master_scripts/html-templates/single_file_details.html ('K') | « cluster_telemetry/telemetry_master_scripts/html-templates/single_file_details.html ('k') | cluster_telemetry/telemetry_master_scripts/json_summary_combiner_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cluster_telemetry/telemetry_master_scripts/json_summary_combiner.py

diff --git a/cluster_telemetry/telemetry_master_scripts/json_summary_combiner.py b/cluster_telemetry/telemetry_master_scripts/json_summary_combiner.py

index 8d67535de42a77e13f90424e298ecc33445fa7a3..fe33900d49f2cad5be8a6e0eb1a82a6e04066537 100644

--- a/cluster_telemetry/telemetry_master_scripts/json_summary_combiner.py

+++ b/cluster_telemetry/telemetry_master_scripts/json_summary_combiner.py

@@ -44,14 +44,13 @@ GS_FILES_LOCATION_WHITE_DIFFS_TEMPLATE_VAR = 'gs_http_files_location_whitediffs'

class FileInfo(object):

"""Container class that holds all file data."""

def __init__(self, file_name, skp_location, num_pixels_differing,

- percent_pixels_differing, weighted_diff_measure,

+ percent_pixels_differing,

max_diff_per_channel, perceptual_diff):

self.file_name = file_name

self.diff_file_name = _GetDiffFileName(self.file_name)

self.skp_location = skp_location

self.num_pixels_differing = num_pixels_differing

self.percent_pixels_differing = percent_pixels_differing

- self.weighted_diff_measure = weighted_diff_measure

self.max_diff_per_channel = max_diff_per_channel

self.perceptual_diff = perceptual_diff

@@ -98,8 +97,6 @@ def CombineJsonSummaries(json_summaries_dir):

json_summary_constants.JSONKEY_NUM_PIXELS_DIFFERING]

percent_pixels_differing = failed_file[

json_summary_constants.JSONKEY_PERCENT_PIXELS_DIFFERING]

- weighted_diff_measure = failed_file[

- json_summary_constants.JSONKEY_WEIGHTED_DIFF_MEASURE]

max_diff_per_channel = failed_file[

json_summary_constants.JSONKEY_MAX_DIFF_PER_CHANNEL]

perceptual_diff = failed_file[

@@ -110,7 +107,6 @@ def CombineJsonSummaries(json_summaries_dir):

skp_location=skp_location,

num_pixels_differing=num_pixels_differing,

percent_pixels_differing=percent_pixels_differing,

- weighted_diff_measure=weighted_diff_measure,

max_diff_per_channel=max_diff_per_channel,

perceptual_diff=perceptual_diff)

file_info_list.append(file_info)