Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7294)

Unified Diff: chromeos/network/network_state_handler.h

Issue 330833003: Rely on Service.Visible instead of Manager.Services (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sort services when updated, add test Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_state_handler.h
diff --git a/chromeos/network/network_state_handler.h b/chromeos/network/network_state_handler.h
index 2d2914b2a91ba8454ae1192d395ced6419b5a217..38571dae9c0453229530e3ea70132606029311b5 100644
--- a/chromeos/network/network_state_handler.h
+++ b/chromeos/network/network_state_handler.h
@@ -244,11 +244,6 @@ class CHROMEOS_EXPORT NetworkStateHandler
virtual void UpdateManagedList(ManagedState::ManagedType type,
const base::ListValue& entries) OVERRIDE;
- // Updates the visibility of entries in |network_list_|. This should not
- // contain entries that are not in |network_list_|. Any such entries will be
- // ignored with an error message.
- virtual void UpdateVisibleNetworks(const base::ListValue& entries) OVERRIDE;
-
// The list of profiles changed (i.e. a user has logged in). Re-request
// properties for all services since they may have changed.
virtual void ProfileListChanged() OVERRIDE;
@@ -290,8 +285,7 @@ class CHROMEOS_EXPORT NetworkStateHandler
// Called by |shill_property_handler_| when the service or device list has
// changed and all entries have been updated. This updates the list and
- // notifies observers. If |type| == TYPE_NETWORK this also calls
- // CheckDefaultNetworkChanged().
+ // notifies observers.
virtual void ManagedStateListChanged(
ManagedState::ManagedType type) OVERRIDE;
@@ -311,6 +305,13 @@ class CHROMEOS_EXPORT NetworkStateHandler
friend class NetworkStateHandlerTest;
FRIEND_TEST_ALL_PREFIXES(NetworkStateHandlerTest, NetworkStateHandlerStub);
+ // Sorts the network list. Called when any requested network is updated and
+ // after all network updates have been received.
+ void SortNetworkList();
+
+ // Updates UMA stats. Called once after all requested networks are updated.
+ void UpdateNetworkStats();
+
// NetworkState specific method for UpdateManagedStateProperties which
// notifies observers.
void UpdateNetworkStateProperties(NetworkState* network,

Powered by Google App Engine
This is Rietveld 408576698