Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 3308018: Merge 66847 - 2010-09-06 Justin Schuh <jschuh@chromium.org>... (Closed)

Created:
10 years, 3 months ago by inferno
Modified:
9 years, 7 months ago
Reviewers:
inferno
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/517/
Visibility:
Public.

Description

Merge 66847 - 2010-09-06 Justin Schuh <jschuh@chromium.org>; Reviewed by Nikolas Zimmermann. Make SVG PendingResources use RefPtr https://bugs.webkit.org/show_bug.cgi?id=43587 Convert SVGDocumentExtensions::m_pendingResources to use a RefPtr for pending elements instead of a raw pointer so that pending elements can't be freed prematurely. Test: svg/custom/use-invalid-pattern.svg * rendering/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::registerResource): * svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::addPendingResource): (WebCore::SVGDocumentExtensions::removePendingResource): * svg/SVGDocumentExtensions.h: * svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoDocument): 2010-09-06 Justin Schuh <jschuh@chromium.org>; Reviewed by Nikolas Zimmermann. Test that an invalid pending resource pattern doesn't crash https://bugs.webkit.org/show_bug.cgi?id=43587 * platform/mac-snowleopard/svg: Added. * platform/mac-snowleopard/svg/custom: Added. * platform/mac-snowleopard/svg/custom/use-invalid-pattern-expected.txt: Added. * svg/custom/use-invalid-pattern.svg: Added. BUG=51252 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67108

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M WebCore/rendering/RenderSVGResourceContainer.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M WebCore/svg/SVGDocumentExtensions.h View 3 chunks +4 lines, -3 lines 0 comments Download
M WebCore/svg/SVGDocumentExtensions.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M WebCore/svg/SVGElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
inferno
10 years, 3 months ago (2010-09-09 20:30:25 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698