components/gcm_driver/gcm_client.h - Issue 330733002: Move IdentityProvider usage from GCMDriverDesktop to GCMProfileService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_client.h

Issue 330733002: Move IdentityProvider usage from GCMDriverDesktop to GCMProfileService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address feedback Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/services/gcm/gcm_profile_service.h ('K') | « components/gcm_driver/fake_gcm_driver.cc ('k') | components/gcm_driver/gcm_client_impl.h » ('j') | components/gcm_driver/gcm_driver.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/gcm_client.h

diff --git a/components/gcm_driver/gcm_client.h b/components/gcm_driver/gcm_client.h

index 10f9a995f909d823c16d0f40e9ef7bee6703e20f..200bbabdbdf91075e9456feaadf853339952d7ca 100644

--- a/components/gcm_driver/gcm_client.h

+++ b/components/gcm_driver/gcm_client.h

@@ -198,7 +198,6 @@ class GCMClient {

// connection.

// |chrome_build_info|: chrome info, i.e., version, channel and etc.

// |store_path|: path to the GCM store.

- // |account_ids|: account IDs to be related to the device when checking in.

// |blocking_task_runner|: for running blocking file tasks.

// |url_request_context_getter|: for url requests.

// |delegate|: the delegate whose methods will be called asynchronously in

@@ -206,7 +205,6 @@ class GCMClient {

virtual void Initialize(

const ChromeBuildInfo& chrome_build_info,

const base::FilePath& store_path,

- const std::vector<std::string>& account_ids,

const scoped_refptr<base::SequencedTaskRunner>& blocking_task_runner,

const scoped_refptr<net::URLRequestContextGetter>&

url_request_context_getter,