Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Unified Diff: components/gcm_driver/gcm_driver.h

Issue 330733002: Move IdentityProvider usage from GCMDriverDesktop to GCMProfileService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address feedback Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_driver.h
diff --git a/components/gcm_driver/gcm_driver.h b/components/gcm_driver/gcm_driver.h
index e2fe882532c28d68fd2494c96387cebb949af421..1096c27701d284ed8ff2db6a87da7139dbc7d039 100644
--- a/components/gcm_driver/gcm_driver.h
+++ b/components/gcm_driver/gcm_driver.h
@@ -67,6 +67,14 @@ class GCMDriver {
// been called, no other GCMDriver methods may be used.
virtual void Shutdown();
+ // Call this method when the user signs in to a GAIA account.
+ // TODO(jianli): To be removed when sign-in enforcement is dropped.
+ virtual void SignIn() = 0;
Nicolas Zea 2014/06/13 19:49:31 nit: Given that this should be called upon signin,
jianli 2014/06/13 21:58:04 Renamed to OnSignedIn.
+
+ // Removes all the cached and persisted GCM data. If the GCM service is
+ // restarted after the purge, a new Android ID will be obtained.
+ virtual void Purge() = 0;
+
// Adds a handler for a given app.
virtual void AddAppHandler(const std::string& app_id, GCMAppHandler* handler);
@@ -96,9 +104,6 @@ class GCMDriver {
virtual void SetGCMRecording(const GetGCMStatisticsCallback& callback,
bool recording) = 0;
- // Returns the user name if the profile is signed in. Empty string otherwise.
- virtual std::string SignedInUserName() const = 0;
-
protected:
// Ensures that the GCM service starts (if necessary conditions are met).
virtual GCMClient::Result EnsureStarted() = 0;

Powered by Google App Engine
This is Rietveld 408576698