Clean-up the SandboxSyscall interface

Clean-up the SandboxSyscall interface

Create a new Syscall class with a static method to replace SandboxSyscall()
and clean-up some documentation.

BUG=369594
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277004

[jln (very slow on Chromium), 2014-06-13 02:21:08]

Matthew, could you please take a look at this small cleanup ?

This makes syscall.h the interface for a Syscall class.

[mdempsky, 2014-06-13 03:01:46]

lgtm

Seems fine, modulo nits.

https://chromiumcodereview.appspot.com/330723003/diff/30009/sandbox/linux/sec...
File sandbox/linux/seccomp-bpf/syscall.cc (right):

https://chromiumcodereview.appspot.com/330723003/diff/30009/sandbox/linux/sec...
sandbox/linux/seccomp-bpf/syscall.cc:16: asm(  // We need to be able to tell the
kernel exactly where we made a
Nit: This first block of comments no longer aligns with the rest of the code.

https://chromiumcodereview.appspot.com/330723003/diff/30009/sandbox/linux/sec...
File sandbox/linux/seccomp-bpf/syscall_unittest.cc (right):

https://chromiumcodereview.appspot.com/330723003/diff/30009/sandbox/linux/sec...
sandbox/linux/seccomp-bpf/syscall_unittest.cc:74: errno = 42;
Perhaps set this to a negative value instead?  POSIX requires EFOO values to be
positive, and 42 is a legitimate error number on Linux (albeit ENOMSG is
unlikely to be returned by dup).

[jln (very slow on Chromium), 2014-06-13 06:39:58]

https://chromiumcodereview.appspot.com/330723003/diff/30009/sandbox/linux/sec...
File sandbox/linux/seccomp-bpf/syscall.cc (right):

https://chromiumcodereview.appspot.com/330723003/diff/30009/sandbox/linux/sec...
sandbox/linux/seccomp-bpf/syscall.cc:16: asm(  // We need to be able to tell the
kernel exactly where we made a
On 2014/06/13 03:01:46, mdempsky wrote:
> Nit: This first block of comments no longer aligns with the rest of the code.

Done.

https://chromiumcodereview.appspot.com/330723003/diff/30009/sandbox/linux/sec...
File sandbox/linux/seccomp-bpf/syscall_unittest.cc (right):

https://chromiumcodereview.appspot.com/330723003/diff/30009/sandbox/linux/sec...
sandbox/linux/seccomp-bpf/syscall_unittest.cc:74: errno = 42;
On 2014/06/13 03:01:46, mdempsky wrote:
> Perhaps set this to a negative value instead?  POSIX requires EFOO values to
be
> positive, and 42 is a legitimate error number on Linux (albeit ENOMSG is
> unlikely to be returned by dup).

Done.

[jln (very slow on Chromium), 2014-06-13 06:41:12]

The CQ bit was checked by jln@chromium.org

[commit-bot: I haz the power, 2014-06-13 06:42:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jln@chromium.org/330723003/90001

[commit-bot: I haz the power, 2014-06-13 13:00:01]

Change committed as 277004