Issue 330713002: Revert 276779 "Move adb_profile_chrome under tools/android/"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 330713002: Revert 276779 "Move adb_profile_chrome under tools/android/" (Closed)

Created:
6 years, 6 months ago by please use gerrit instead

Modified:
6 years, 6 months ago

Reviewers:
Sami

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 276779 "Move adb_profile_chrome under tools/android/" Appears to have broken http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/5246 src/tools/android/adb_profile_chrome/main.py: Has executable bit but not shebang or ELF header. Please add the shebang and reland. Sorry for the inconvenience. > Move adb_profile_chrome under tools/android/ > > Move adb_profile_chrome from build/android/ to tools/android/ to make > its purpose clearer. > > BUG=375754 > TEST=tools/android/adb_profile_chrome/run_tests > > Review URL: https://codereview.chromium.org/310413003 TBR=skyostil@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276784

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+-15 lines, -1122 lines)			Patch
M	trunk/src/build/android/adb_profile_chrome	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	trunk/src/build/android/adb_profile_chrome.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/build/android/chrome_profiler/__init__.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/build/android/chrome_profiler/chrome_controller.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/build/android/chrome_profiler/chrome_controller_unittest.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/build/android/chrome_profiler/controllers.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/build/android/chrome_profiler/controllers_unittest.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/build/android/chrome_profiler/main.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/build/android/chrome_profiler/perf_controller.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/build/android/chrome_profiler/perf_controller_unittest.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/build/android/chrome_profiler/profiler.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/build/android/chrome_profiler/profiler_unittest.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/build/android/chrome_profiler/run_tests	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/build/android/chrome_profiler/systrace_controller.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/build/android/chrome_profiler/systrace_controller_unittest.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/build/android/chrome_profiler/trace_packager.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/build/android/chrome_profiler/trace_packager_unittest.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/build/android/chrome_profiler/ui.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/build/android/chrome_profiler/util.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	trunk/src/tools/android/adb_profile_chrome.py	View	1 chunk	+0 lines, -13 lines	0 comments	Download
D	trunk/src/tools/android/adb_profile_chrome/__init__.py	View	1 chunk	+0 lines, -8 lines	0 comments	Download
D	trunk/src/tools/android/adb_profile_chrome/chrome_controller.py	View	1 chunk	+0 lines, -102 lines	0 comments	Download
D	trunk/src/tools/android/adb_profile_chrome/chrome_controller_unittest.py	View	1 chunk	+0 lines, -46 lines	0 comments	Download
D	trunk/src/tools/android/adb_profile_chrome/controllers.py	View	1 chunk	+0 lines, -16 lines	0 comments	Download
D	trunk/src/tools/android/adb_profile_chrome/controllers_unittest.py	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	trunk/src/tools/android/adb_profile_chrome/main.py	View	1 chunk	+0 lines, -248 lines	0 comments	Download
D	trunk/src/tools/android/adb_profile_chrome/perf_controller.py	View	1 chunk	+0 lines, -186 lines	0 comments	Download
D	trunk/src/tools/android/adb_profile_chrome/perf_controller_unittest.py	View	1 chunk	+0 lines, -38 lines	0 comments	Download
D	trunk/src/tools/android/adb_profile_chrome/profiler.py	View	1 chunk	+0 lines, -83 lines	0 comments	Download
D	trunk/src/tools/android/adb_profile_chrome/profiler_unittest.py	View	1 chunk	+0 lines, -78 lines	0 comments	Download
D	trunk/src/tools/android/adb_profile_chrome/run_tests	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	trunk/src/tools/android/adb_profile_chrome/systrace_controller.py	View	1 chunk	+0 lines, -95 lines	0 comments	Download
D	trunk/src/tools/android/adb_profile_chrome/systrace_controller_unittest.py	View	1 chunk	+0 lines, -36 lines	0 comments	Download
D	trunk/src/tools/android/adb_profile_chrome/trace_packager.py	View	1 chunk	+0 lines, -94 lines	0 comments	Download
D	trunk/src/tools/android/adb_profile_chrome/trace_packager_unittest.py	View	1 chunk	+0 lines, -35 lines	0 comments	Download
D	trunk/src/tools/android/adb_profile_chrome/ui.py	View	1 chunk	+0 lines, -25 lines	0 comments	Download
D	trunk/src/tools/android/adb_profile_chrome/util.py	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	trunk/src/tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

please use gerrit instead

6 years, 6 months ago (2014-06-12 20:22:03 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r276784 (tree was closed).

Expand Messages | Collapse Messages