Move adb_profile_chrome under tools/android/

Move adb_profile_chrome under tools/android/
    
Move adb_profile_chrome from build/android/ to tools/android/ to make
its purpose clearer.
    
BUG=375754
TEST=tools/android/adb_profile_chrome/run_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276779

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277031

[Sami, 2014-06-04 15:49:47]

How do you like this organization?

[Sami, 2014-06-10 14:01:27]

On 2014/06/04 at 15:49:47, Sami wrote:
> How do you like this organization?

Ping, WDYT?-)

[bulach, 2014-06-10 14:51:55]

lgtm, but if I may... :)

ADB_TRACE=1 adb shell ls

I'd suggest renaming to just "trace"? it's already under tools/android, right,
so "adb_" is not that informative.. 

just want to avoid confusion when people start saying "run adb trace and send me
the logs.." :)

wdyt?

[Sami, 2014-06-10 15:05:00]

On 2014/06/10 at 14:51:55, bulach wrote:
> lgtm, but if I may... :)
> 
> ADB_TRACE=1 adb shell ls
> 
> I'd suggest renaming to just "trace"? it's already under tools/android, right,
so "adb_" is not that informative.. 
> 
> just want to avoid confusion when people start saying "run adb trace and send
me the logs.." :)
> 
> wdyt?

Ack, all the good names are taken :) I think "trace" is a little too generic, so
maybe I'll just keep this as tools/android/adb_profile_chrome instead of
introducing yet another name.

[bulach, 2014-06-10 15:10:58]

On 2014/06/10 15:05:00, Sami wrote:
> On 2014/06/10 at 14:51:55, bulach wrote:
> > lgtm, but if I may... :)
> > 
> > ADB_TRACE=1 adb shell ls
> > 
> > I'd suggest renaming to just "trace"? it's already under tools/android,
right,
> so "adb_" is not that informative.. 
> > 
> > just want to avoid confusion when people start saying "run adb trace and
send
> me the logs.." :)
> > 
> > wdyt?
> 
> Ack, all the good names are taken :) I think "trace" is a little too generic,
so
> maybe I'll just keep this as tools/android/adb_profile_chrome instead of
> introducing yet another name.

sgtm!
I'd remove the "adb_" prefix, since it's under tools/android..
but then.... the current "adb_gdb" scripts would need a new prefix. :(
yeah, probably best as you said, tools/android/adb_profile_chrome...

[Sami, 2014-06-12 15:38:01]

On 2014/06/10 at 15:10:58, bulach wrote:
> I'd remove the "adb_" prefix, since it's under tools/android..
> but then.... the current "adb_gdb" scripts would need a new prefix. :(
> yeah, probably best as you said, tools/android/adb_profile_chrome...

Done!

Dominik, could you rubberstamp
tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py
please?

[Dominik Grewe, 2014-06-12 16:19:49]

On 2014/06/12 15:38:01, Sami wrote:
> On 2014/06/10 at 15:10:58, bulach wrote:
> > I'd remove the "adb_" prefix, since it's under tools/android..
> > but then.... the current "adb_gdb" scripts would need a new prefix. :(
> > yeah, probably best as you said, tools/android/adb_profile_chrome...
> 
> Done!
> 
> Dominik, could you rubberstamp
> tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler.py
> please?

lgtm!

You might want to change the subject according to the description.

[Sami, 2014-06-12 16:34:28]

On 2014/06/12 at 16:19:49, dominikg wrote:
> You might want to change the subject according to the description.

Oh, thanks! New review tool X)

[Sami, 2014-06-12 16:34:35]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2014-06-12 16:35:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skyostil@chromium.org/310413003/20001

[commit-bot: I haz the power, 2014-06-12 19:52:35]

Change committed as 276779

[please use gerrit instead, 2014-06-12 20:23:12]

A revert of this patch was created in https://codereview.chromium.org/330713002/

Reason for the revert:

Appears to have broken
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

  src/tools/android/adb_profile_chrome/main.py: Has executable bit but
  not shebang or ELF header.

Please add the shebang and reland. Sorry for the inconvenience.

[Sami, 2014-06-13 10:48:31]

On 2014/06/12 20:23:12, Rouslan Solomakhin wrote:
> A revert of this patch was created in
https://codereview.chromium.org/330713002/
> 
> Reason for the revert:
> 
> Appears to have broken
>
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...
> 
>   src/tools/android/adb_profile_chrome/main.py: Has executable bit but
>   not shebang or ELF header.
> 
> Please add the shebang and reland. Sorry for the inconvenience.

Hmm, this seems like a bug somewhere. My patch should have removed the
executable bit:

  Index: tools/android/adb_profile_chrome/main.py                               
                                                                                
                  
  diff --git a/build/android/chrome_profiler/main.py
b/tools/android/adb_profile_chrome/main.py                                      
                                              
  old mode 100755                                                               
                                                                                
                  
  new mode 100644                                                               
                                                                                
                  
  similarity index 97%                                                          
                                                                                
                  
  rename from build/android/chrome_profiler/main.py                             
                                                                                
                  
  rename to tools/android/adb_profile_chrome/main.py 

but the committed result still has svn:executable. I think it may be the
combination of a move and perm change that tripped things up. I'll add the
shebang here temporarily and remove it in a separate step.

[Sami, 2014-06-13 10:52:00]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2014-06-13 10:53:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/skyostil@chromium.org/310413003/40001

[Sami, 2014-06-13 10:54:44]

Opened an infra bug: https://code.google.com/p/chromium/issues/detail?id=384293

[commit-bot: I haz the power, 2014-06-13 14:18:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-06-13 16:27:30]

Change committed as 277031