Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 330703005: Revert of Change HistoryService::QueryURL to use CancelableTaskTracker (Closed)

Created:
6 years, 6 months ago by Feng Qian
Modified:
6 years, 6 months ago
CC:
chromium-reviews, davidben+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, tburkard+watch_chromium.org, browser-components-watch_chromium.org, gavinp+prer_chromium.org, dominich+watch_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Change HistoryService::QueryURL to use CancelableTaskTracker (https://codereview.chromium.org/314293005/) Reason for revert: Break Clank ToT build: https://uberchromegw.corp.google.com/i/clank.tot/builders/instrumentation-yakju-clankium-tot/builds/29577/steps/compile/logs/stdio Original issue's description: > Change HistoryService::QueryURL to use CancelableTaskTracker > > The callback no longer receive an HistoryService::Handle as first parameter > and the caller should use the returned base::CancelableTaskTrasker::TaskId > to cancel a request early. > > Instead of passing a CancelableRequestConsumer to the query, the caller > pass a base::CancelableTaskTracker. The lifetime of the callback can be > associated to the request by using base::Passed(). > > Remove unused types and fix usage of the values passed to the result > callback (check success before using the URLRow or the VisitVector). > > BUG=371818 > TBR=bauerb,sky,asargent,gavinp,shess,pkasting > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276739 TBR=blundell@chromium.org,bauerb@chromium.org,sky@chromium.org,asargent@chromium.org,gavinp@chromium.org,shess@chromium.org,pkasting@chromium.org,sdefresne@chromium.org NOTREECHECKS=true NOTRY=true BUG=371818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -177 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/custom_home_pages_table_model.h View 3 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/custom_home_pages_table_model.cc View 5 chunks +37 lines, -32 lines 0 comments Download
M chrome/browser/extensions/api/history/history_api.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/history/history_api.cc View 1 chunk +9 lines, -7 lines 0 comments Download
M chrome/browser/history/history_backend.h View 2 chunks +3 lines, -11 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 2 chunks +20 lines, -17 lines 0 comments Download
M chrome/browser/history/history_marshaling.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/history/history_service.h View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/history/history_service.cc View 2 chunks +6 lines, -15 lines 0 comments Download
M chrome/browser/history/history_unittest.cc View 3 chunks +9 lines, -12 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.h View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.cc View 2 chunks +22 lines, -24 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 3 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Feng Qian
Created Revert of Change HistoryService::QueryURL to use CancelableTaskTracker
6 years, 6 months ago (2014-06-12 22:09:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/feng@chromium.org/330703005/1
6 years, 6 months ago (2014-06-12 22:10:00 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 22:14:00 UTC) #3
Message was sent while issue was closed.
Change committed as 276825

Powered by Google App Engine
This is Rietveld 408576698