Chromium Code Reviews
DescriptionRevert of Change HistoryService::QueryURL to use CancelableTaskTracker (https://codereview.chromium.org/314293005/)
Reason for revert:
Break Clank ToT build:
https://uberchromegw.corp.google.com/i/clank.tot/builders/instrumentation-yakju-clankium-tot/builds/29577/steps/compile/logs/stdio
Original issue's description:
> Change HistoryService::QueryURL to use CancelableTaskTracker
>
> The callback no longer receive an HistoryService::Handle as first parameter
> and the caller should use the returned base::CancelableTaskTrasker::TaskId
> to cancel a request early.
>
> Instead of passing a CancelableRequestConsumer to the query, the caller
> pass a base::CancelableTaskTracker. The lifetime of the callback can be
> associated to the request by using base::Passed().
>
> Remove unused types and fix usage of the values passed to the result
> callback (check success before using the URLRow or the VisitVector).
>
> BUG=371818
> TBR=bauerb,sky,asargent,gavinp,shess,pkasting
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276739
TBR=blundell@chromium.org,bauerb@chromium.org,sky@chromium.org,asargent@chromium.org,gavinp@chromium.org,shess@chromium.org,pkasting@chromium.org,sdefresne@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=371818
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276825
Patch Set 1 #
Created: 6 years, 6 months ago
(Patch set is too large to download)
Messages
Total messages: 3 (0 generated)
|