Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1493)

Unified Diff: chrome/browser/extensions/api/history/history_api.cc

Issue 330703005: Revert of Change HistoryService::QueryURL to use CancelableTaskTracker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/history/history_api.h ('k') | chrome/browser/history/history_backend.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/history/history_api.cc
diff --git a/chrome/browser/extensions/api/history/history_api.cc b/chrome/browser/extensions/api/history/history_api.cc
index a454ce2dbba8b816c157eb3c43a2ee60bc9df981..bf0608865f676d5df3dc43837696378e3722452e 100644
--- a/chrome/browser/extensions/api/history/history_api.cc
+++ b/chrome/browser/extensions/api/history/history_api.cc
@@ -301,20 +301,22 @@
GetProfile(), Profile::EXPLICIT_ACCESS);
hs->QueryURL(url,
true, // Retrieve full history of a URL.
+ &cancelable_consumer_,
base::Bind(&HistoryGetVisitsFunction::QueryComplete,
- base::Unretained(this)),
- &task_tracker_);
+ base::Unretained(this)));
+
return true;
}
void HistoryGetVisitsFunction::QueryComplete(
+ HistoryService::Handle request_service,
bool success,
- const history::URLRow& url_row,
- const history::VisitVector& visits) {
+ const history::URLRow* url_row,
+ history::VisitVector* visits) {
VisitItemList visit_item_vec;
- if (success && !visits.empty()) {
- for (history::VisitVector::const_iterator iterator = visits.begin();
- iterator != visits.end();
+ if (visits && !visits->empty()) {
+ for (history::VisitVector::iterator iterator = visits->begin();
+ iterator != visits->end();
++iterator) {
visit_item_vec.push_back(make_linked_ptr(
GetVisitItem(*iterator).release()));
« no previous file with comments | « chrome/browser/extensions/api/history/history_api.h ('k') | chrome/browser/history/history_backend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698