Source/web/WebRemoteFrameImpl.h - Issue 330613002: Copying text closes the keyboard and the text input gets unfocused, forcing virtual keyboard is get…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebRemoteFrameImpl.h

Issue 330613002: Copying text closes the keyboard and the text input gets unfocused, forcing virtual keyboard is get… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated code based on self review. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebRemoteFrameImpl.h

diff --git a/Source/web/WebRemoteFrameImpl.h b/Source/web/WebRemoteFrameImpl.h

index ffa739dc372d10270f4e754ac4c2f4115aa3fca5..59c439ef364be11732d7c7bb6c17034c3e333fe8 100644

--- a/Source/web/WebRemoteFrameImpl.h

+++ b/Source/web/WebRemoteFrameImpl.h

@@ -94,6 +94,7 @@ public:

virtual WebURLLoader* createAssociatedURLLoader(const WebURLLoaderOptions&) OVERRIDE;

virtual unsigned unloadListenerCount() const OVERRIDE;

virtual void replaceSelection(const WebString&) OVERRIDE;

+ virtual bool setCaretSelectionFromRangeSelection() OVERRIDE;

virtual void insertText(const WebString&) OVERRIDE;

virtual void setMarkedText(const WebString&, unsigned location, unsigned length) OVERRIDE;

virtual void unmarkText() OVERRIDE;

« Source/web/WebLocalFrameImpl.cpp ('K') | « Source/web/WebLocalFrameImpl.cpp ('k') | Source/web/WebRemoteFrameImpl.cpp » ('j') | no next file with comments »