Source/web/WebRemoteFrameImpl.cpp - Issue 330613002: Copying text closes the keyboard and the text input gets unfocused, forcing virtual keyboard is get…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebRemoteFrameImpl.cpp

Issue 330613002: Copying text closes the keyboard and the text input gets unfocused, forcing virtual keyboard is get… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated code based on self review. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebRemoteFrameImpl.cpp

diff --git a/Source/web/WebRemoteFrameImpl.cpp b/Source/web/WebRemoteFrameImpl.cpp

index 12bc07a2ec9b0382bd6056d26758ead1eb82bbf5..fcc93cf4a161a7791a06511de4bdf0f383964582 100644

--- a/Source/web/WebRemoteFrameImpl.cpp

+++ b/Source/web/WebRemoteFrameImpl.cpp

@@ -382,6 +382,12 @@ void WebRemoteFrameImpl::replaceSelection(const WebString&)

ASSERT_NOT_REACHED();

}

+bool WebRemoteFrameImpl::setCaretSelectionFromRangeSelection()

+ ASSERT_NOT_REACHED();

+ return false;

void WebRemoteFrameImpl::insertText(const WebString&)

{

ASSERT_NOT_REACHED();

« Source/web/WebLocalFrameImpl.cpp ('K') | « Source/web/WebRemoteFrameImpl.h ('k') | public/web/WebFrame.h » ('j') | no next file with comments »