Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: LayoutTests/http/tests/media/media-source/mediasource-errors.html

Issue 330593005: HTMLMediaElement::webMediaPlayer() should never be null if m_readyState >= HAVE_METADATA (media eng… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated failing mediasource test Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/http/tests/media/video-load-metadata-decode-error.cgi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/media/media-source/mediasource-errors.html
diff --git a/LayoutTests/http/tests/media/media-source/mediasource-errors.html b/LayoutTests/http/tests/media/media-source/mediasource-errors.html
index 6f61b0e558531cbecd0bd2f5a1655ee01067559f..82fbde267b659052bd9cba5c8ad1ee1f537659fd 100644
--- a/LayoutTests/http/tests/media/media-source/mediasource-errors.html
+++ b/LayoutTests/http/tests/media/media-source/mediasource-errors.html
@@ -104,9 +104,6 @@
assert_equals(mediaElement.readyState, HTMLMediaElement.HAVE_METADATA);
test.expectEvent(mediaElement, "error", "mediaElement error.");
- test.expectEvent(mediaSource, "sourceended", "mediaSource ended.");
acolwell GONE FROM CHROMIUM 2014/06/25 16:20:07 This line should not be removed. The sourceended e
Srirama 2014/06/26 09:37:08 Done.
- test.expectEvent(mediaSource, "sourceclose", "mediaSource closed.");
-
mediaSource.endOfStream("decode");
});
@@ -114,9 +111,6 @@
{
assert_true(mediaElement.error != null);
assert_equals(mediaElement.error.code, MediaError.MEDIA_ERR_DECODE);
-
- assert_equals(mediaSource.sourceBuffers.length, 0);
- assert_equals(mediaSource.readyState, "closed");
acolwell GONE FROM CHROMIUM 2014/06/25 16:20:07 This should be changed to check for "ended".
Srirama 2014/06/26 09:37:08 Done.
test.done();
});
}, "Signaling 'decode' error via endOfStream() after initialization segment has been appended and the HTMLMediaElement has reached HAVE_METADATA.");
@@ -135,9 +129,6 @@
assert_equals(mediaElement.readyState, HTMLMediaElement.HAVE_METADATA);
test.expectEvent(mediaElement, "error", "mediaElement error.");
- test.expectEvent(mediaSource, "sourceended", "mediaSource ended.");
acolwell GONE FROM CHROMIUM 2014/06/25 16:20:07 ditto.
Srirama 2014/06/26 09:37:07 Done.
- test.expectEvent(mediaSource, "sourceclose", "mediaSource closed.");
-
mediaSource.endOfStream("network");
});
@@ -145,9 +136,6 @@
{
assert_true(mediaElement.error != null);
assert_equals(mediaElement.error.code, MediaError.MEDIA_ERR_NETWORK);
-
- assert_equals(mediaSource.sourceBuffers.length, 0);
- assert_equals(mediaSource.readyState, "closed");
acolwell GONE FROM CHROMIUM 2014/06/25 16:20:07 ditto
Srirama 2014/06/26 09:37:08 Done.
test.done();
});
}, "Signaling 'network' error via endOfStream() after initialization segment has been appended and the HTMLMediaElement has reached HAVE_METADATA.");
« no previous file with comments | « no previous file | LayoutTests/http/tests/media/video-load-metadata-decode-error.cgi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698