Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/http/tests/media/media-source/mediasource-errors.html

Issue 330593005: HTMLMediaElement::webMediaPlayer() should never be null if m_readyState >= HAVE_METADATA (media eng… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated failing mediasource test Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | LayoutTests/http/tests/media/video-load-metadata-decode-error.cgi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <script src="/w3c/resources/testharness.js"></script> 4 <script src="/w3c/resources/testharness.js"></script>
5 <script src="/w3c/resources/testharnessreport.js"></script> 5 <script src="/w3c/resources/testharnessreport.js"></script>
6 <script src="mediasource-util.js"></script> 6 <script src="mediasource-util.js"></script>
7 <link rel='stylesheet' href='/w3c/resources/testharness.css'> 7 <link rel='stylesheet' href='/w3c/resources/testharness.css'>
8 </head> 8 </head>
9 <body> 9 <body>
10 <div id="log"></div> 10 <div id="log"></div>
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 97
98 test.expectEvent(sourceBuffer, "updateend", "mediaSegment append ended."); 98 test.expectEvent(sourceBuffer, "updateend", "mediaSegment append ended.");
99 test.expectEvent(mediaElement, "loadedmetadata", "mediaElement m etadata."); 99 test.expectEvent(mediaElement, "loadedmetadata", "mediaElement m etadata.");
100 sourceBuffer.appendBuffer(initSegment); 100 sourceBuffer.appendBuffer(initSegment);
101 101
102 test.waitForExpectedEvents(function() 102 test.waitForExpectedEvents(function()
103 { 103 {
104 assert_equals(mediaElement.readyState, HTMLMediaElement.HAVE _METADATA); 104 assert_equals(mediaElement.readyState, HTMLMediaElement.HAVE _METADATA);
105 105
106 test.expectEvent(mediaElement, "error", "mediaElement error. "); 106 test.expectEvent(mediaElement, "error", "mediaElement error. ");
107 test.expectEvent(mediaSource, "sourceended", "mediaSource en ded.");
acolwell GONE FROM CHROMIUM 2014/06/25 16:20:07 This line should not be removed. The sourceended e
Srirama 2014/06/26 09:37:08 Done.
108 test.expectEvent(mediaSource, "sourceclose", "mediaSource cl osed.");
109
110 mediaSource.endOfStream("decode"); 107 mediaSource.endOfStream("decode");
111 }); 108 });
112 109
113 test.waitForExpectedEvents(function() 110 test.waitForExpectedEvents(function()
114 { 111 {
115 assert_true(mediaElement.error != null); 112 assert_true(mediaElement.error != null);
116 assert_equals(mediaElement.error.code, MediaError.MEDIA_ERR_ DECODE); 113 assert_equals(mediaElement.error.code, MediaError.MEDIA_ERR_ DECODE);
117
118 assert_equals(mediaSource.sourceBuffers.length, 0);
119 assert_equals(mediaSource.readyState, "closed");
acolwell GONE FROM CHROMIUM 2014/06/25 16:20:07 This should be changed to check for "ended".
Srirama 2014/06/26 09:37:08 Done.
120 test.done(); 114 test.done();
121 }); 115 });
122 }, "Signaling 'decode' error via endOfStream() after initialization segment has been appended and the HTMLMediaElement has reached HAVE_METADATA."); 116 }, "Signaling 'decode' error via endOfStream() after initialization segment has been appended and the HTMLMediaElement has reached HAVE_METADATA.");
123 117
124 ErrorTest(function(test, mediaElement, mediaSource, segmentInfo, sou rceBuffer, mediaData) 118 ErrorTest(function(test, mediaElement, mediaSource, segmentInfo, sou rceBuffer, mediaData)
125 { 119 {
126 var initSegment = MediaSourceUtil.extractSegmentData(mediaData, segmentInfo.init); 120 var initSegment = MediaSourceUtil.extractSegmentData(mediaData, segmentInfo.init);
127 assert_equals(mediaElement.readyState, HTMLMediaElement.HAVE_NOT HING); 121 assert_equals(mediaElement.readyState, HTMLMediaElement.HAVE_NOT HING);
128 122
129 test.expectEvent(sourceBuffer, "updateend", "mediaSegment append ended."); 123 test.expectEvent(sourceBuffer, "updateend", "mediaSegment append ended.");
130 test.expectEvent(mediaElement, "loadedmetadata", "mediaElement m etadata."); 124 test.expectEvent(mediaElement, "loadedmetadata", "mediaElement m etadata.");
131 sourceBuffer.appendBuffer(initSegment); 125 sourceBuffer.appendBuffer(initSegment);
132 126
133 test.waitForExpectedEvents(function() 127 test.waitForExpectedEvents(function()
134 { 128 {
135 assert_equals(mediaElement.readyState, HTMLMediaElement.HAVE _METADATA); 129 assert_equals(mediaElement.readyState, HTMLMediaElement.HAVE _METADATA);
136 130
137 test.expectEvent(mediaElement, "error", "mediaElement error. "); 131 test.expectEvent(mediaElement, "error", "mediaElement error. ");
138 test.expectEvent(mediaSource, "sourceended", "mediaSource en ded.");
acolwell GONE FROM CHROMIUM 2014/06/25 16:20:07 ditto.
Srirama 2014/06/26 09:37:07 Done.
139 test.expectEvent(mediaSource, "sourceclose", "mediaSource cl osed.");
140
141 mediaSource.endOfStream("network"); 132 mediaSource.endOfStream("network");
142 }); 133 });
143 134
144 test.waitForExpectedEvents(function() 135 test.waitForExpectedEvents(function()
145 { 136 {
146 assert_true(mediaElement.error != null); 137 assert_true(mediaElement.error != null);
147 assert_equals(mediaElement.error.code, MediaError.MEDIA_ERR_ NETWORK); 138 assert_equals(mediaElement.error.code, MediaError.MEDIA_ERR_ NETWORK);
148
149 assert_equals(mediaSource.sourceBuffers.length, 0);
150 assert_equals(mediaSource.readyState, "closed");
acolwell GONE FROM CHROMIUM 2014/06/25 16:20:07 ditto
Srirama 2014/06/26 09:37:08 Done.
151 test.done(); 139 test.done();
152 }); 140 });
153 }, "Signaling 'network' error via endOfStream() after initialization segment has been appended and the HTMLMediaElement has reached HAVE_METADATA.") ; 141 }, "Signaling 'network' error via endOfStream() after initialization segment has been appended and the HTMLMediaElement has reached HAVE_METADATA.") ;
154 </script> 142 </script>
155 </body> 143 </body>
156 </html> 144 </html>
OLDNEW
« no previous file with comments | « no previous file | LayoutTests/http/tests/media/video-load-metadata-decode-error.cgi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698