Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 330513002: Disentangle updating the ScrollingCoordinator from RenderLayerCompositor (Closed)

Created:
6 years, 6 months ago by abarth-chromium
Modified:
6 years, 6 months ago
Reviewers:
chrishtr
CC:
ojan, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, esprehn, jamesr, jchaffraix+rendering, kenneth.christiansen, leviw+renderwatch, pdr., rune+blink, Ian Vollick, zoltan1
Visibility:
Public.

Description

Disentangle updating the ScrollingCoordinator from RenderLayerCompositor We only need to update the ScrollingCoordinator once at the root of the frame tree. We shouldn't be poking at it at every level of the recursion. This CL finally achieves my dream of controlling RenderLayerCompositor::updateIfNeeded with just the CompositingUpdateType enum. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176046

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M Source/core/frame/FrameView.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.h View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
abarth-chromium
6 years, 6 months ago (2014-06-11 20:46:32 UTC) #1
chrishtr
On 2014/06/11 at 20:46:32, abarth wrote: > Is there only one scrolling coordinator for the ...
6 years, 6 months ago (2014-06-11 21:05:14 UTC) #2
abarth-chromium
On 2014/06/11 at 21:05:14, chrishtr wrote: > Is there only one scrolling coordinator for the ...
6 years, 6 months ago (2014-06-11 21:29:30 UTC) #3
chrishtr
lgtm
6 years, 6 months ago (2014-06-12 00:37:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/330513002/1
6 years, 6 months ago (2014-06-12 00:38:09 UTC) #5
ojan
https://codereview.chromium.org/330513002/diff/1/Source/core/frame/FrameView.cpp File Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/330513002/diff/1/Source/core/frame/FrameView.cpp#newcode2838 Source/core/frame/FrameView.cpp:2838: // FIXME: Is it really possible to be inCompositingMode ...
6 years, 6 months ago (2014-06-12 03:49:57 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-12 05:29:02 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 05:38:45 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/11911)
6 years, 6 months ago (2014-06-12 05:38:46 UTC) #9
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-12 17:44:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/330513002/20001
6 years, 6 months ago (2014-06-12 17:44:57 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 21:24:56 UTC) #12
Message was sent while issue was closed.
Change committed as 176046

Powered by Google App Engine
This is Rietveld 408576698