Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 330513002: Disentangle updating the ScrollingCoordinator from RenderLayerCompositor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix assert Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/page/scrolling/ScrollingCoordinator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 2814 matching lines...) Expand 10 before | Expand all | Expand 10 after
2825 2825
2826 void FrameView::updateLayoutAndStyleForPainting() 2826 void FrameView::updateLayoutAndStyleForPainting()
2827 { 2827 {
2828 // Updating layout can run script, which can tear down the FrameView. 2828 // Updating layout can run script, which can tear down the FrameView.
2829 RefPtr<FrameView> protector(this); 2829 RefPtr<FrameView> protector(this);
2830 2830
2831 updateLayoutAndStyleIfNeededRecursive(); 2831 updateLayoutAndStyleIfNeededRecursive();
2832 2832
2833 if (RenderView* view = renderView()) { 2833 if (RenderView* view = renderView()) {
2834 InspectorInstrumentation::willUpdateLayerTree(view->frame()); 2834 InspectorInstrumentation::willUpdateLayerTree(view->frame());
2835
2835 view->compositor()->updateIfNeededRecursive(); 2836 view->compositor()->updateIfNeededRecursive();
2837
2838 if (view->compositor()->inCompositingMode() && m_frame->isMainFrame())
2839 m_frame->page()->scrollingCoordinator()->updateAfterCompositingChang eIfNeeded();
2840
2836 InspectorInstrumentation::didUpdateLayerTree(view->frame()); 2841 InspectorInstrumentation::didUpdateLayerTree(view->frame());
2837 } 2842 }
2838 2843
2839 scrollContentsIfNeededRecursive(); 2844 scrollContentsIfNeededRecursive();
2840 } 2845 }
2841 2846
2842 void FrameView::updateLayoutAndStyleIfNeededRecursive() 2847 void FrameView::updateLayoutAndStyleIfNeededRecursive()
2843 { 2848 {
2844 // We have to crawl our entire tree looking for any FrameViews that need 2849 // We have to crawl our entire tree looking for any FrameViews that need
2845 // layout and make sure they are up to date. 2850 // layout and make sure they are up to date.
(...skipping 427 matching lines...) Expand 10 before | Expand all | Expand 10 after
3273 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) 3278 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation)
3274 { 3279 {
3275 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); 3280 ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
3276 if (AXObjectCache* cache = axObjectCache()) { 3281 if (AXObjectCache* cache = axObjectCache()) {
3277 cache->remove(scrollbar); 3282 cache->remove(scrollbar);
3278 cache->handleScrollbarUpdate(this); 3283 cache->handleScrollbarUpdate(this);
3279 } 3284 }
3280 } 3285 }
3281 3286
3282 } // namespace WebCore 3287 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/page/scrolling/ScrollingCoordinator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698