Manually commit changes that cause false-alarm on check-webkit-style.

Manually commit changes that cause false-alarm on check-webkit-style.

BUG=381876
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176369

[c.shu, 2014-06-17 19:00:41]

These changes need to be committed manually to by-pass style check. I believe
the errors from check-webkit-style are false-alarm and need to be addressed
separately.
I opened a bug but didn't see a quick work-around.
https://code.google.com/p/chromium/issues/detail?id=385670

[c.shu, 2014-06-17 20:50:22]

On 2014/06/17 19:00:41, c.shu wrote:
> These changes need to be committed manually to by-pass style check. I believe
> the errors from check-webkit-style are false-alarm and need to be addressed
> separately.
> I opened a bug but didn't see a quick work-around.
> https://code.google.com/p/chromium/issues/detail?id=385670

haraken and nbarth, can you commit the change after lgtm? Thanks.

[eseidel, 2014-06-17 21:05:13]

https://codereview.chromium.org/330323005/diff/20001/Source/core/editing/Undo...
File Source/core/editing/UndoStack.cpp (right):

https://codereview.chromium.org/330323005/diff/20001/Source/core/editing/Undo...
Source/core/editing/UndoStack.cpp:28: #include "core/editing/UndoStack.h"
I'm surprised this would cause a style warning?  Or why this would be needed. 
This is the .cpp corresponding to that header.  Do we use full paths in that
case?

[c.shu, 2014-06-17 21:10:31]

https://codereview.chromium.org/330323005/diff/20001/Source/core/editing/Undo...
File Source/core/editing/UndoStack.cpp (right):

https://codereview.chromium.org/330323005/diff/20001/Source/core/editing/Undo...
Source/core/editing/UndoStack.cpp:28: #include "core/editing/UndoStack.h"
On 2014/06/17 21:05:13, eseidel wrote:
> I'm surprised this would cause a style warning?  Or why this would be needed. 
> This is the .cpp corresponding to that header.  Do we use full paths in that
> case?

Actually this is the only file that does not cause style warning in this CL. But
we use full path for all other instances when including the own headers, except
this one.

[haraken, 2014-06-17 23:41:37]

LGTM, I'll land this manually for you.

[c.shu, 2014-06-18 00:19:15]

On 2014/06/17 23:41:37, haraken wrote:
> LGTM, I'll land this manually for you.

thanks a lot, haraken.

[haraken, 2014-06-18 00:58:19]

probably I can try NOTRY=true.

[haraken, 2014-06-18 00:58:21]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-06-18 00:59:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/c.shu@samsung.com/330323005/20001

[commit-bot: I haz the power, 2014-06-18 01:00:03]

Change committed as 176369

[Nils Barth (inactive), 2014-06-18 01:32:25]

On 2014/06/18 00:58:19, haraken wrote:
> probably I can try NOTRY=true.

Thanks, and yup, NOTRY=true and NOTREECHECKS=true avoid dcommits, per docs:
http://dev.chromium.org/developers/contributing-code/direct-commit

[Nils Barth (inactive), 2014-06-18 02:01:37]

There were 2 real errors masked by the false alarms;
I'm fixing them in a followup.
https://codereview.chromium.org/347473002/

https://codereview.chromium.org/330323005/diff/20001/Source/core/html/parser/...
File Source/core/html/parser/HTMLConstructionSite.cpp (right):

https://codereview.chromium.org/330323005/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLConstructionSite.cpp:28: #include
"core/html/parser/HTMLTreeBuilder.h"
This is a real error:
the primary include is wrong (should be HTMLConstructionSite, not
HTMLTreeBuilder).

https://codereview.chromium.org/330323005/diff/20001/Source/core/svg/SVGPathS...
File Source/core/svg/SVGPathSegListTearOff.h (right):

https://codereview.chromium.org/330323005/diff/20001/Source/core/svg/SVGPathS...
Source/core/svg/SVGPathSegListTearOff.h:34: #include "core/SVGNames.h"
? Is this triggering an error ?
Looks fine to me (and checks ok).

https://codereview.chromium.org/330323005/diff/20001/Source/core/xml/XSLTProc...
File Source/core/xml/XSLTProcessorLibxslt.cpp (right):

https://codereview.chromium.org/330323005/diff/20001/Source/core/xml/XSLTProc...
Source/core/xml/XSLTProcessorLibxslt.cpp:29: #include <libxslt/xsltutils.h>
This is a real error: system includes come *after* other includes.
[include-system]
http://dev.chromium.org/blink/coding-style#TOC-include-Statements

This is ensured by alphabetical order:
< comes *after* "

[c.shu, 2014-06-18 14:17:32]

thanks for the fix, guys.