Source/modules/geolocation/Geolocation.idl - Issue 330293002: Removing unnecessary PerWorldBindings for DOM API calls that are monitored by Activity Logger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/geolocation/Geolocation.idl

Issue 330293002: Removing unnecessary PerWorldBindings for DOM API calls that are monitored by Activity Logger. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: createElement reverted Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/geolocation/Geolocation.idl

diff --git a/Source/modules/geolocation/Geolocation.idl b/Source/modules/geolocation/Geolocation.idl

index 736e71579d68a35e7898ae08ff293bb394e96dfe..ca1b5a5e61d1bdcacbc26360a9bd31eb0a8937a0 100644

--- a/Source/modules/geolocation/Geolocation.idl

+++ b/Source/modules/geolocation/Geolocation.idl

@@ -29,12 +29,12 @@

NoInterfaceObject,

] interface Geolocation {

// FIXME: should be: PositionOptions options: need PositionOptions.idl and dictionary http:/crbug.com/321462

- [Custom, PerWorldBindings, LogActivity] void getCurrentPosition(PositionCallback successCallback,

+ [Custom, LogActivity] void getCurrentPosition(PositionCallback successCallback,

optional PositionErrorCallback errorCallback,

optional object options);

// FIXME: should be: PositionOptions options: need PositionOptions.idl and dictionary http:/crbug.com/321462

- [Custom, PerWorldBindings, LogActivity] long watchPosition(PositionCallback successCallback,

+ [Custom, LogActivity] long watchPosition(PositionCallback successCallback,

optional PositionErrorCallback errorCallback,

optional object options);

« Source/core/frame/Window.idl ('K') | « Source/core/storage/Storage.idl ('k') | Source/modules/webdatabase/WindowWebDatabase.idl » ('j') | no next file with comments »