Removing unnecessary PerWorldBindings for DOM API calls that are monitored by Activity Logger.

Source/core/frame/Window.idl

Index: Source/core/frame/Window.idl
diff --git a/Source/core/frame/Window.idl b/Source/core/frame/Window.idl
index 70ce11219b4233b31f9b6e19c630311bebe01aa7..3871c050776f7e509950ddef0cf92c0e339c1c63 100644
--- a/Source/core/frame/Window.idl
+++ b/Source/core/frame/Window.idl
@@ -43,9 +43,9 @@
     [Replaceable, MeasureAs=BarPropScrollbars] readonly attribute BarProp scrollbars;
     [Replaceable, MeasureAs=BarPropStatusbar] readonly attribute BarProp statusbar;
     [Replaceable, MeasureAs=BarPropToolbar] readonly attribute BarProp toolbar;
-    [PerWorldBindings, LogActivity=GetterOnly] readonly attribute Navigator navigator;
+    [LogActivity=GetterOnly] readonly attribute Navigator navigator;
     [Replaceable] readonly attribute Navigator clientInformation;
-    [DoNotCheckSecurity, Unforgeable, Replaceable, PerWorldBindings, LogActivity, PutForwards=href] readonly attribute Location location;
+    [DoNotCheckSecurity, Unforgeable, Replaceable, LogActivity, PutForwards=href] readonly attribute Location location;
     [Custom, MeasureAs=WindowEvent, NotEnumerable] attribute Event event;
 
     Selection getSelection();
@@ -156,10 +156,10 @@
     [MeasureAs=PrefixedConvertPointFromNodeToPage] WebKitPoint webkitConvertPointFromNodeToPage([Default=Undefined] optional Node node,
                                                                                                 [Default=Undefined] optional WebKitPoint p);
 
-    [RuntimeEnabled=ApplicationCache, PerWorldBindings, LogActivity=GetterOnly] readonly attribute ApplicationCache applicationCache;
+    [RuntimeEnabled=ApplicationCache, LogActivity=GetterOnly] readonly attribute ApplicationCache applicationCache;
 
-    [RuntimeEnabled=SessionStorage, PerWorldBindings, LogActivity=GetterOnly, RaisesException=Getter] readonly attribute Storage sessionStorage;
-    [RuntimeEnabled=LocalStorage, PerWorldBindings, LogActivity=GetterOnly, RaisesException=Getter] readonly attribute Storage localStorage;
+    [RuntimeEnabled=SessionStorage, LogActivity=GetterOnly, RaisesException=Getter] readonly attribute Storage sessionStorage;
+    [RuntimeEnabled=LocalStorage, LogActivity=GetterOnly, RaisesException=Getter] readonly attribute Storage localStorage;
 
     // This is the interface orientation in degrees. Some examples are:
     //  0 is straight up; -90 is when the device is rotated 90 clockwise;
@@ -196,7 +196,7 @@
     attribute EventHandler onwebkitanimationiteration;
     attribute EventHandler onwebkitanimationstart;
     attribute EventHandler onwebkittransitionend;
-    [PerWorldBindings, LogActivity=SetterOnly] attribute EventHandler onwheel;

[haraken, 2014/06/16 14:57:47]

If we just remove [PerWorldBindings] from DOM attributes that do not have
[LogAllWorlds], it will change behavior, won't it?

Before this CL, those DOM attributes are not logged in the main world. After
this CL, those DOM attributes are logged in the main world.

[pmarch, 2014/06/16 15:11:01]

Nice catch. You are absolutely right.

For API calls that do not have LogAllWorlds, I need to check if the world is
isolated world. Let me fix this.

On 2014/06/16 14:57:47, haraken wrote:

[haraken, 2014/06/16 15:16:49]

Probably was this a reason why you've been observing performance regression in
several benchmarks? If we can skip logging in the main world, the overhead of
not having [PerWorldBindings] would be very small.

Either way, I'm fine with landing this CL first and then removing more
[PerWorldBindings] in a follow-up.

+    [LogActivity=SetterOnly] attribute EventHandler onwheel;
 
     [MeasureAs=WindowCaptureEvents] void captureEvents();
     [MeasureAs=WindowReleaseEvents] void releaseEvents();