Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 330273002: Oilpan: trace Event.currentTarget. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: trace Event.currentTarget. Strongly keep track of the current target. For tidiness, also trace the 'parent' back reference on the XHR progress event throttling part object. R=zerny@chromium.org,ager@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176112

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update XMLHttpRequestProgressEventThrottle comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M Source/core/events/Event.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/Event.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/core/xml/XMLHttpRequestProgressEventThrottle.h View 1 1 chunk +5 lines, -2 lines 0 comments Download
M Source/core/xml/XMLHttpRequestProgressEventThrottle.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sof
Please take a look.
6 years, 6 months ago (2014-06-13 11:55:27 UTC) #1
zerny-chromium
lgtm
6 years, 6 months ago (2014-06-13 12:00:33 UTC) #2
Mads Ager (chromium)
LGTM2 https://codereview.chromium.org/330273002/diff/1/Source/core/xml/XMLHttpRequestProgressEventThrottle.h File Source/core/xml/XMLHttpRequestProgressEventThrottle.h (right): https://codereview.chromium.org/330273002/diff/1/Source/core/xml/XMLHttpRequestProgressEventThrottle.h#newcode84 Source/core/xml/XMLHttpRequestProgressEventThrottle.h:84: // Weak pointer to our XMLHttpRequest object as ...
6 years, 6 months ago (2014-06-13 12:14:58 UTC) #3
sof
https://codereview.chromium.org/330273002/diff/1/Source/core/xml/XMLHttpRequestProgressEventThrottle.h File Source/core/xml/XMLHttpRequestProgressEventThrottle.h (right): https://codereview.chromium.org/330273002/diff/1/Source/core/xml/XMLHttpRequestProgressEventThrottle.h#newcode84 Source/core/xml/XMLHttpRequestProgressEventThrottle.h:84: // Weak pointer to our XMLHttpRequest object as it ...
6 years, 6 months ago (2014-06-13 12:31:55 UTC) #4
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-13 12:32:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/330273002/2
6 years, 6 months ago (2014-06-13 12:32:08 UTC) #6
haraken
LGTM
6 years, 6 months ago (2014-06-13 13:20:42 UTC) #7
sof
The CQ bit was unchecked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-13 14:30:58 UTC) #8
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-13 14:31:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/330273002/2
6 years, 6 months ago (2014-06-13 14:32:15 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 14:52:43 UTC) #11
Message was sent while issue was closed. 
Change committed as 176112

Powered by Google App Engine
This is Rietveld 408576698