Source/core/xml/XMLHttpRequestProgressEventThrottle.h - Issue 330273002: Oilpan: trace Event.currentTarget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/XMLHttpRequestProgressEventThrottle.h

Issue 330273002: Oilpan: trace Event.currentTarget. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update XMLHttpRequestProgressEventThrottle comment Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/xml/XMLHttpRequestProgressEventThrottle.h

diff --git a/Source/core/xml/XMLHttpRequestProgressEventThrottle.h b/Source/core/xml/XMLHttpRequestProgressEventThrottle.h

index a4c5833656af756814a9a0f779a6b72e5aed4b8b..06769fbb8f49ceb5470b2379126a6036f3e25994 100644

--- a/Source/core/xml/XMLHttpRequestProgressEventThrottle.h

+++ b/Source/core/xml/XMLHttpRequestProgressEventThrottle.h

@@ -81,8 +81,11 @@ private:

bool hasEventToDispatch() const;

- // Weak pointer to our XMLHttpRequest object as it is the one holding us.

- EventTarget* m_target;

+ // Non-Oilpan, keep a weak pointer to our XMLHttpRequest object as it is

+ // the one holding us. With Oilpan, a simple strong Member can be used -

+ // this XMLHttpRequestProgressEventThrottle (part) object dies together

+ // with the XMLHttpRequest object.

+ RawPtrWillBeMember<EventTarget> m_target;

bool m_lengthComputable;

unsigned long long m_loaded;