Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 354833004: DevTools: [CodeMirror] roll CodeMirror to version @e20d175 (Closed)

Created:
6 years, 6 months ago by lushnikov
Modified:
6 years, 6 months ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [CodeMirror] roll CodeMirror to version @e20d175 This patch rolls CodeMirror and all of its modes. This roll also adds "rebeccapurple" support to devtools code highlighter. Instructions for CodeMirror rolling could be found here: https://sites.google.com/a/chromium.org/devtools-codemirror-rolling/ R=apavlov@chromium.org TBR=apavlov, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176976

Patch Set 1 #

Patch Set 2 : update formatters, rebase tests #

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1552 lines, -1011 lines) Patch
M LayoutTests/inspector/syntax-highlight.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/syntax-highlight-css-expected.txt View 1 3 chunks +14 lines, -14 lines 0 comments Download
M LayoutTests/inspector/syntax-highlight-html-expected.txt View 1 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/inspector/syntax-highlight-javascript-expected.txt View 1 1 chunk +14 lines, -14 lines 0 comments Download
M Source/devtools/front_end/cm/LICENSE View 2 chunks +1 line, -5 lines 0 comments Download
M Source/devtools/front_end/cm/clike.js View 8 chunks +92 lines, -15 lines 0 comments Download
M Source/devtools/front_end/cm/closebrackets.js View 2 chunks +5 lines, -1 line 0 comments Download
M Source/devtools/front_end/cm/codemirror.css View 3 chunks +29 lines, -0 lines 0 comments Download
M Source/devtools/front_end/cm/codemirror.js View 56 chunks +149 lines, -104 lines 0 comments Download
M Source/devtools/front_end/cm/coffeescript.js View 4 chunks +18 lines, -4 lines 0 comments Download
M Source/devtools/front_end/cm/comment.js View 2 chunks +14 lines, -0 lines 0 comments Download
M Source/devtools/front_end/cm/css.js View 12 chunks +397 lines, -319 lines 0 comments Download
M Source/devtools/front_end/cm/headlesscodemirror.js View 3 chunks +4 lines, -1 line 0 comments Download
M Source/devtools/front_end/cm/htmlembedded.js View 3 chunks +15 lines, -2 lines 0 comments Download
M Source/devtools/front_end/cm/htmlmixed.js View 3 chunks +19 lines, -3 lines 0 comments Download
M Source/devtools/front_end/cm/javascript.js View 25 chunks +116 lines, -50 lines 0 comments Download
M Source/devtools/front_end/cm/markselection.js View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/devtools/front_end/cm/matchbrackets.js View 5 chunks +11 lines, -4 lines 0 comments Download
M Source/devtools/front_end/cm/overlay.js View 4 chunks +33 lines, -7 lines 0 comments Download
M Source/devtools/front_end/cm/php.js View 7 chunks +118 lines, -17 lines 0 comments Download
M Source/devtools/front_end/cm/python.js View 2 chunks +290 lines, -312 lines 0 comments Download
M Source/devtools/front_end/cm/shell.js View 4 chunks +21 lines, -2 lines 0 comments Download
M Source/devtools/front_end/cm/xml.js View 8 chunks +160 lines, -121 lines 0 comments Download
M Source/devtools/front_end/script_formatter_worker/ScriptFormatterWorker.js View 1 2 2 chunks +21 lines, -8 lines 0 comments Download
M Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 6 months ago (2014-06-25 13:20:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/354833004/1
6 years, 6 months ago (2014-06-25 13:21:04 UTC) #2
lushnikov
6 years, 6 months ago (2014-06-25 13:21:22 UTC) #3
lushnikov
The CQ bit was unchecked by lushnikov@chromium.org
6 years, 6 months ago (2014-06-25 13:26:53 UTC) #4
lushnikov
@apavlov: changes to codemirror html/css modes are not backward-compatible; please take a look on changes ...
6 years, 6 months ago (2014-06-26 10:33:58 UTC) #5
apavlov
LGTM To be on the safe side, you could split token types by the / ...
6 years, 6 months ago (2014-06-26 10:42:05 UTC) #6
lushnikov
Thank you for the review. Updated patch to use |.split(/ +/)| to split token in ...
6 years, 6 months ago (2014-06-26 10:52:40 UTC) #7
lushnikov
6 years, 6 months ago (2014-06-26 10:54:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r176976 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698