*wip* NSS: handle chromeos system slot.

net/cert/nss_cert_database_chromeos.h

Index: net/cert/nss_cert_database_chromeos.h
diff --git a/net/cert/nss_cert_database_chromeos.h b/net/cert/nss_cert_database_chromeos.h
index 07a1e67f31afa4cc50cbd40f28d432444fd0df30..461572701424dd3a897daf2cd7a8e571dde0b968 100644
--- a/net/cert/nss_cert_database_chromeos.h
+++ b/net/cert/nss_cert_database_chromeos.h
@@ -17,7 +17,8 @@ namespace net {
 class NET_EXPORT NSSCertDatabaseChromeOS : public NSSCertDatabase {
  public:
   NSSCertDatabaseChromeOS(crypto::ScopedPK11Slot public_slot,
-                          crypto::ScopedPK11Slot private_slot);
+                          crypto::ScopedPK11Slot private_slot,
+                          crypto::ScopedPK11Slot system_slot);

[pneubeck (no reviews), 2014/06/13 12:40:42]

Please add a comment explaining the meaning of each slot.
The naming is also inconsistent with regard to public/private vs.  user/system.

How about always explicitly calling the slots
{public,private}_{system,user}_slot ?

Why is there only one system_slot (which is assigned always a private slot later
in this CL) and not both public_system_slot and private_system_slot? (at least
document the reason)

[mattm, 2014/06/24 03:16:45]

done.
That's more an artifact of the nss_util::GetPrivateNSSKeySlot function being
overloaded on chromeos to now mean the system slot.
public_slot is the NSS software db, private and system slot are TPM backed.
There isn't a system-wide software db.

   virtual ~NSSCertDatabaseChromeOS();
 
   // NSSCertDatabase implementation.