*wip* NSS: handle chromeos system slot.

net/cert/nss_cert_database_chromeos.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_NSS_CERT_DATABASE_CHROMEOS_
 #define NET_CERT_NSS_CERT_DATABASE_CHROMEOS_
 
 #include "base/callback.h"
 #include "base/memory/weak_ptr.h"
 #include "crypto/scoped_nss_types.h"
 #include "net/base/net_export.h"
 #include "net/cert/nss_cert_database.h"
 #include "net/cert/nss_profile_filter_chromeos.h"
 
 namespace net {
 
 class NET_EXPORT NSSCertDatabaseChromeOS : public NSSCertDatabase {
  public:
   NSSCertDatabaseChromeOS(crypto::ScopedPK11Slot public_slot,
-                          crypto::ScopedPK11Slot private_slot);
+                          crypto::ScopedPK11Slot private_slot,
+                          crypto::ScopedPK11Slot system_slot);

[pneubeck (no reviews), 2014/06/13 12:40:42]

Please add a comment explaining the meaning of each slot.
The naming is also inconsistent with regard to public/private vs.  user/system.

How about always explicitly calling the slots
{public,private}_{system,user}_slot ?

Why is there only one system_slot (which is assigned always a private slot later
in this CL) and not both public_system_slot and private_system_slot? (at least
document the reason)

[mattm, 2014/06/24 03:16:45]

done.
That's more an artifact of the nss_util::GetPrivateNSSKeySlot function being
overloaded on chromeos to now mean the system slot.
public_slot is the NSS software db, private and system slot are TPM backed.
There isn't a system-wide software db.

   virtual ~NSSCertDatabaseChromeOS();
 
   // NSSCertDatabase implementation.
   virtual void ListCertsSync(CertificateList* certs) OVERRIDE;
   virtual void ListCerts(const NSSCertDatabase::ListCertsCallback& callback)
       OVERRIDE;
   virtual crypto::ScopedPK11Slot GetPublicSlot() const OVERRIDE;
   virtual crypto::ScopedPK11Slot GetPrivateSlot() const OVERRIDE;
   virtual void ListModules(CryptoModuleList* modules, bool need_rw) const
       OVERRIDE;
@@ skipping 13 matching lines @@
   crypto::ScopedPK11Slot public_slot_;
   crypto::ScopedPK11Slot private_slot_;
   NSSProfileFilterChromeOS profile_filter_;
 
   DISALLOW_COPY_AND_ASSIGN(NSSCertDatabaseChromeOS);
 };
 
 }  // namespace net
 
 #endif  // NET_CERT_NSS_CERT_DATABASE_CHROMEOS_