Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/modules/serviceworkers/ServiceWorker.h

Issue 330173003: Make ServiceWorker an ActiveDOMObject (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix hasPendingActivity Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« LayoutTests/http/tests/serviceworker/service-worker-gc.html ('K') | « LayoutTests/virtual/serviceworker/http/tests/serviceworker/service-worker-gc-expected.txt ('k') | Source/modules/serviceworkers/ServiceWorker.cpp » ('j') | Source/modules/serviceworkers/ServiceWorker.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/ServiceWorker.h
diff --git a/Source/modules/serviceworkers/ServiceWorker.h b/Source/modules/serviceworkers/ServiceWorker.h
index 58a40ea43e8145cdfe3a95e98223ac0bee06f158..3904cfafb62ef6277584ec25112e379f851ef22d 100644
--- a/Source/modules/serviceworkers/ServiceWorker.h
+++ b/Source/modules/serviceworkers/ServiceWorker.h
@@ -74,6 +74,10 @@ public:
// AbstractWorker overrides.
virtual const AtomicString& interfaceName() const OVERRIDE;
+ // ActiveDOMObject overrides.
dominicc (has gone to gerrit) 2014/06/12 22:23:38 Let's make these private?
falken 2014/06/13 19:22:59 Done.
+ virtual bool hasPendingActivity() const OVERRIDE;
+ virtual void stop() OVERRIDE;
+
private:
class ThenFunction;
@@ -84,6 +88,9 @@ private:
OwnPtr<blink::WebServiceWorker> m_outerWorker;
bool m_isPromisePending;
+
+ // Whether ActiveDOMObject::stop has been called.
dominicc (has gone to gerrit) 2014/06/12 22:23:38 We can probably omit this comment.
falken 2014/06/13 19:22:59 Done.
+ bool m_contextStopped;
};
} // namespace WebCore
« LayoutTests/http/tests/serviceworker/service-worker-gc.html ('K') | « LayoutTests/virtual/serviceworker/http/tests/serviceworker/service-worker-gc-expected.txt ('k') | Source/modules/serviceworkers/ServiceWorker.cpp » ('j') | Source/modules/serviceworkers/ServiceWorker.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698