Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: tools/perf/benchmarks/media.py

Issue 329723004: Change results.Add to results.AddResult in endure, media metrics and media benchmark. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/measurements/endure.py » ('j') | tools/perf/measurements/endure.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/media.py
diff --git a/tools/perf/benchmarks/media.py b/tools/perf/benchmarks/media.py
index f881547a3a49742d895a97a9f6674ed6ecf245d6..c674192b693f5e47374dc0f67cf32175d4020031 100644
--- a/tools/perf/benchmarks/media.py
+++ b/tools/perf/benchmarks/media.py
@@ -5,6 +5,8 @@
from measurements import media
from telemetry import test
from telemetry.page import page_measurement
+from telemetry.value import scalar
+from telemetry.value import list_of_scalar_values
tonyg 2014/06/11 03:39:39 nit: alphabetize
class _MSEMeasurement(page_measurement.PageMeasurement):
@@ -13,11 +15,17 @@ class _MSEMeasurement(page_measurement.PageMeasurement):
trace = media_metric['id'] if 'id' in media_metric else None
metrics = media_metric['metrics'] if 'metrics' in media_metric else []
for m in metrics:
+ trace_name = '%s.%s' % (m, trace)
if isinstance(metrics[m], list):
- values = [float(v) for v in metrics[m]]
+ results.AddValue(list_of_scalar_values.ListOfScalarValues(
+ results.current_page, trace_name, unit='ms',
+ values=[float(v) for v in metrics[m]],
+ important=True))
+
else:
- values = float(metrics[m])
- results.Add(trace, 'ms', values, chart_name=m)
+ results.AddValue(scalar.ScalarValue(
+ results.current_page, trace_name, unit='ms',
+ value=float(metrics[m]), important=True))
class Media(test.Test):
« no previous file with comments | « no previous file | tools/perf/measurements/endure.py » ('j') | tools/perf/measurements/endure.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698