Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 329553003: Delete now-unnecessary hack for 0-size layers, now that we use transformOrigin (Closed)

Created:
6 years, 6 months ago by chrishtr
Modified:
6 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Visibility:
Public.

Description

Delete now-unnecessary hack for 0-size layers, now that we use transformOrigin instead of anchorPoint. The hack is no longer necessary because transformOrigin is an additive offset, as opposed to a multiplicative one. BUG=372837 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -198 lines) Patch
M LayoutTests/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
D LayoutTests/virtual/softwarecompositing/layer-creation/overlap-transformed-preserved-3d-expected.txt View 1 chunk +0 lines, -168 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 3 chunks +3 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
chrishtr
6 years, 6 months ago (2014-06-10 16:39:54 UTC) #1
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-10 17:15:37 UTC) #2
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 6 months ago (2014-06-10 17:50:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/329553003/1
6 years, 6 months ago (2014-06-10 17:51:37 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 19:03:43 UTC) #5
Message was sent while issue was closed.
Change committed as 175911

Powered by Google App Engine
This is Rietveld 408576698