Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 329533002: DevTools: Added test that LiveEdit doesn't crash on breakpoint (Closed)

Created:
6 years, 6 months ago by kozyatinskiy1
Modified:
6 years, 6 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master2
Visibility:
Public.

Description

Crash test case: 1. Open page with javascript 2. Add breakpoint 3. Stop on breakpoint 4. Use live edit and save script The test worked for Chromium revision until May 30. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176101 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176226

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M LayoutTests/inspector/sources/debugger/live-edit.html View 1 2 2 chunks +39 lines, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/live-edit-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
kozyatinskiy1
6 years, 6 months ago (2014-06-10 14:24:03 UTC) #1
kozyatinskiy1
On 2014/06/10 14:24:03, kozyatinskiy wrote: Now test fails. Probably a problem in the following changes ...
6 years, 6 months ago (2014-06-10 14:27:01 UTC) #2
vsevik
lgtm, we should land this once v8 is fixed. https://codereview.chromium.org/329533002/diff/1/LayoutTests/inspector/sources/debugger/live-edit.html File LayoutTests/inspector/sources/debugger/live-edit.html (right): https://codereview.chromium.org/329533002/diff/1/LayoutTests/inspector/sources/debugger/live-edit.html#newcode124 LayoutTests/inspector/sources/debugger/live-edit.html:124: ...
6 years, 6 months ago (2014-06-10 15:29:56 UTC) #3
kozyatinskiy1
On 2014/06/10 15:29:56, vsevik wrote: > lgtm, we should land this once v8 is fixed. ...
6 years, 6 months ago (2014-06-10 15:48:44 UTC) #4
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 6 months ago (2014-06-13 07:00:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kozyatinskiy@google.com/329533002/40001
6 years, 6 months ago (2014-06-13 07:01:37 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-13 08:18:33 UTC) #7
commit-bot: I haz the power
Change committed as 176101
6 years, 6 months ago (2014-06-13 09:23:17 UTC) #8
Dirk Pranke
On 2014/06/13 09:23:17, I haz the power (commit-bot) wrote: > Change committed as 176101 Unfortunately, ...
6 years, 6 months ago (2014-06-13 20:37:54 UTC) #9
vsevik
lgtm
6 years, 6 months ago (2014-06-16 16:15:57 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 17:20:32 UTC) #11
Message was sent while issue was closed.
Change committed as 176226

Powered by Google App Engine
This is Rietveld 408576698