Issue 301563004: Refactor after break target computation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 301563004: Refactor after break target computation. (Closed)

Created:
6 years, 7 months ago by Yang

Modified:
6 years, 6 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Refactor after break target computation. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21560

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -76 lines)			Patch
M	src/debug.h	View	5 chunks	+8 lines, -6 lines	0 comments	Download
M	src/debug.cc	View	6 chunks	+22 lines, -53 lines	0 comments	Download
M	src/liveedit.h	View	2 chunks	+18 lines, -17 lines	0 comments	Download
M	src/liveedit.cc	View	1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

Committed patchset #1 manually as r21560 (presubmit successful).

6 years, 6 months ago (2014-05-28 10:41:20 UTC) #3

kozyatinskiy1

6 years, 6 months ago (2014-06-10 14:40:46 UTC) #4

Message was sent while issue was closed.

On 2014/05/28 10:41:20, Yang wrote:
> Committed patchset #1 manually as r21560 (presubmit successful).

Hi, Yang.

I added test to Blink's layout tests: https://codereview.chromium.org/329533002
This test fails after revision about May 30.
Could you please have a look on test and fix it, if the problem is in this
patch?

Expand Messages | Collapse Messages