Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4184)

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/open_file.cc

Issue 329483002: [fsp] Group arguments for API methods and events in dictionaries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleaned up. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/operations/open_file.cc
diff --git a/chrome/browser/chromeos/file_system_provider/operations/open_file.cc b/chrome/browser/chromeos/file_system_provider/operations/open_file.cc
index d56cb0b0774bd3f53fb437e9bc60f9ccb9bea1d9..b0592e97feac95e6ba8701db41202c3c036d6074 100644
--- a/chrome/browser/chromeos/file_system_provider/operations/open_file.cc
+++ b/chrome/browser/chromeos/file_system_provider/operations/open_file.cc
@@ -31,21 +31,25 @@ OpenFile::~OpenFile() {
}
bool OpenFile::Execute(int request_id) {
- scoped_ptr<base::ListValue> values(new base::ListValue);
- values->AppendString(file_path_.AsUTF8Unsafe());
+ scoped_ptr<base::DictionaryValue> values(new base::DictionaryValue);
+ values->SetString("filePath", file_path_.AsUTF8Unsafe());
switch (mode_) {
case ProvidedFileSystemInterface::OPEN_FILE_MODE_READ:
- values->AppendString(extensions::api::file_system_provider::ToString(
- extensions::api::file_system_provider::OPEN_FILE_MODE_READ));
+ values->SetString(
+ "mode",
+ extensions::api::file_system_provider::ToString(
+ extensions::api::file_system_provider::OPEN_FILE_MODE_READ));
break;
case ProvidedFileSystemInterface::OPEN_FILE_MODE_WRITE:
- values->AppendString(extensions::api::file_system_provider::ToString(
- extensions::api::file_system_provider::OPEN_FILE_MODE_WRITE));
+ values->SetString(
+ "mode",
+ extensions::api::file_system_provider::ToString(
+ extensions::api::file_system_provider::OPEN_FILE_MODE_WRITE));
break;
}
- values->AppendBoolean(create_);
+ values->SetBoolean("create", create_);
return SendEvent(
request_id,

Powered by Google App Engine
This is Rietveld 408576698