Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: chrome/browser/chromeos/file_system_provider/operations/open_file.cc

Issue 329483002: [fsp] Group arguments for API methods and events in dictionaries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleaned up. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/file_system_provider/operations/open_file.h" 5 #include "chrome/browser/chromeos/file_system_provider/operations/open_file.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "chrome/common/extensions/api/file_system_provider.h" 9 #include "chrome/common/extensions/api/file_system_provider.h"
10 #include "chrome/common/extensions/api/file_system_provider_internal.h" 10 #include "chrome/common/extensions/api/file_system_provider_internal.h"
(...skipping 13 matching lines...) Expand all
24 file_path_(file_path), 24 file_path_(file_path),
25 mode_(mode), 25 mode_(mode),
26 create_(create), 26 create_(create),
27 callback_(callback) { 27 callback_(callback) {
28 } 28 }
29 29
30 OpenFile::~OpenFile() { 30 OpenFile::~OpenFile() {
31 } 31 }
32 32
33 bool OpenFile::Execute(int request_id) { 33 bool OpenFile::Execute(int request_id) {
34 scoped_ptr<base::ListValue> values(new base::ListValue); 34 scoped_ptr<base::DictionaryValue> values(new base::DictionaryValue);
35 values->AppendString(file_path_.AsUTF8Unsafe()); 35 values->SetString("filePath", file_path_.AsUTF8Unsafe());
36 36
37 switch (mode_) { 37 switch (mode_) {
38 case ProvidedFileSystemInterface::OPEN_FILE_MODE_READ: 38 case ProvidedFileSystemInterface::OPEN_FILE_MODE_READ:
39 values->AppendString(extensions::api::file_system_provider::ToString( 39 values->SetString(
40 extensions::api::file_system_provider::OPEN_FILE_MODE_READ)); 40 "mode",
41 extensions::api::file_system_provider::ToString(
42 extensions::api::file_system_provider::OPEN_FILE_MODE_READ));
41 break; 43 break;
42 case ProvidedFileSystemInterface::OPEN_FILE_MODE_WRITE: 44 case ProvidedFileSystemInterface::OPEN_FILE_MODE_WRITE:
43 values->AppendString(extensions::api::file_system_provider::ToString( 45 values->SetString(
44 extensions::api::file_system_provider::OPEN_FILE_MODE_WRITE)); 46 "mode",
47 extensions::api::file_system_provider::ToString(
48 extensions::api::file_system_provider::OPEN_FILE_MODE_WRITE));
45 break; 49 break;
46 } 50 }
47 51
48 values->AppendBoolean(create_); 52 values->SetBoolean("create", create_);
49 53
50 return SendEvent( 54 return SendEvent(
51 request_id, 55 request_id,
52 extensions::api::file_system_provider::OnOpenFileRequested::kEventName, 56 extensions::api::file_system_provider::OnOpenFileRequested::kEventName,
53 values.Pass()); 57 values.Pass());
54 } 58 }
55 59
56 void OpenFile::OnSuccess(int request_id, 60 void OpenFile::OnSuccess(int request_id,
57 scoped_ptr<RequestValue> result, 61 scoped_ptr<RequestValue> result,
58 bool has_more) { 62 bool has_more) {
59 // File handle is the same as request id of the OpenFile operation. 63 // File handle is the same as request id of the OpenFile operation.
60 callback_.Run(request_id, base::File::FILE_OK); 64 callback_.Run(request_id, base::File::FILE_OK);
61 } 65 }
62 66
63 void OpenFile::OnError(int /* request_id */, base::File::Error error) { 67 void OpenFile::OnError(int /* request_id */, base::File::Error error) {
64 callback_.Run(0 /* file_handle */, error); 68 callback_.Run(0 /* file_handle */, error);
65 } 69 }
66 70
67 } // namespace operations 71 } // namespace operations
68 } // namespace file_system_provider 72 } // namespace file_system_provider
69 } // namespace chromeos 73 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698