Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 329463005: Revert 21720: "Introduce FieldIndex to unify and abstract property/field offset" (Closed)

Created:
6 years, 6 months ago by danno
Modified:
6 years, 6 months ago
Reviewers:
mstarzginer, Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Revert 21720: "Introduce FieldIndex to unify and abstract property/field offset" Due to assorted failures R=mstarzinger@chromium.org TBR=mstarzginer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21732

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -435 lines) Patch
M src/arm/stub-cache-arm.cc View 7 chunks +27 lines, -12 lines 0 comments Download
M src/arm64/stub-cache-arm64.cc View 7 chunks +27 lines, -12 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M src/code-stubs.h View 3 chunks +33 lines, -17 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 5 chunks +17 lines, -14 lines 0 comments Download
M src/deoptimizer.cc View 2 chunks +2 lines, -4 lines 0 comments Download
D src/field-index.h View 1 chunk +0 lines, -123 lines 0 comments Download
D src/field-index.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D src/field-index-inl.h View 1 chunk +0 lines, -80 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 5 chunks +27 lines, -12 lines 0 comments Download
M src/ic.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/ic.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M src/json-parser.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/json-stringifier.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/objects.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/objects.cc View 13 chunks +24 lines, -23 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 3 chunks +16 lines, -10 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/property.h View 4 chunks +53 lines, -5 lines 0 comments Download
M src/property.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime.cc View 6 chunks +20 lines, -26 lines 0 comments Download
M src/string-stream.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/stub-cache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/stub-cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/stub-cache-x64.cc View 4 chunks +27 lines, -12 lines 0 comments Download
M test/cctest/test-heap.cc View 3 chunks +8 lines, -14 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
6 years, 6 months ago (2014-06-10 08:48:21 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
6 years, 6 months ago (2014-06-10 08:49:00 UTC) #2
danno
6 years, 6 months ago (2014-06-10 09:00:33 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r21732 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698