src/objects-printer.cc - Issue 329463005: Revert 21720: "Introduce FieldIndex to unify and abstract property/field offset"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-printer.cc

Issue 329463005: Revert 21720: "Introduce FieldIndex to unify and abstract property/field offset" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-printer.cc

diff --git a/src/objects-printer.cc b/src/objects-printer.cc

index 54a7b5532bb31e4129597de1aa916e4dca5a672f..c51c04e3fe223e01367dcb8843405338039e9623 100644

--- a/src/objects-printer.cc

+++ b/src/objects-printer.cc

@@ -232,9 +232,9 @@ void JSObject::PrintProperties(FILE* out) {

PrintF(out, ": ");

switch (descs->GetType(i)) {

case FIELD: {

- FieldIndex index = FieldIndex::ForDescriptor(map(), i);

+ int index = descs->GetFieldIndex(i);

RawFastPropertyAt(index)->ShortPrint(out);

- PrintF(out, " (field at offset %d)\n", index.property_index());

+ PrintF(out, " (field at offset %d)\n", index);

break;

}

case CONSTANT:

« no previous file with comments | « src/objects-inl.h ('k') | src/property.h » ('j') | no next file with comments »