ash/shelf/shelf_layout_manager.cc - Issue 32943006: [Refactor] Replace kFullscreenUsesMinimalChromeKey with WindowState::hide_shelf_when_fullscreen()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shelf/shelf_layout_manager.cc

Issue 32943006: [Refactor] Replace kFullscreenUsesMinimalChromeKey with WindowState::hide_shelf_when_fullscreen() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/shelf/shelf_layout_manager.cc

diff --git a/ash/shelf/shelf_layout_manager.cc b/ash/shelf/shelf_layout_manager.cc

index e270547ced2087880f92e1c0f76aa52d94efcb00..10c6578dd22948f9cd0bec2207bd955949c85807 100644

--- a/ash/shelf/shelf_layout_manager.cc

+++ b/ash/shelf/shelf_layout_manager.cc

@@ -26,7 +26,6 @@

#include "ash/wm/lock_state_controller.h"

#include "ash/wm/mru_window_tracker.h"

#include "ash/wm/window_animations.h"

-#include "ash/wm/window_properties.h"

#include "ash/wm/window_state.h"

#include "ash/wm/window_util.h"

#include "ash/wm/workspace_controller.h"

@@ -544,9 +543,8 @@ bool ShelfLayoutManager::FullscreenWithMinimalChrome() const {

const aura::Window* window = controller->GetTopmostFullscreenWindow();

if (!window)

return false;

- if (!window->GetProperty(kFullscreenUsesMinimalChromeKey))

- return false;

- return true;

+ return wm::GetWindowState(window)->fullscreen_type() ==

+ wm::FULLSCREEN_TYPE_IMMERSIVE_MINIMAL_CHROME;

oshima 2013/10/25 15:21:32 Is this only place this fullscreen type is used in

}

// static

« no previous file with comments | « ash/ash_switches.cc ('k') | ash/shelf/shelf_layout_manager_unittest.cc » ('j') | ash/wm/wm_types.h » ('J')