src/ic.cc - Issue 329393005: Allow all Names to be fast property names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic.cc

Issue 329393005: Allow all Names to be fast property names (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic.cc

diff --git a/src/ic.cc b/src/ic.cc

index cd44f8831bbb941641e4e88640d0589698b744a5..cd92af11852c0f77c7140804cf6500e767087474 100644

--- a/src/ic.cc

+++ b/src/ic.cc

@@ -1326,8 +1326,7 @@ MaybeHandle<Object> StoreIC::Store(Handle<Object> object,

TRACE_IC("StoreIC", name);

} else if (can_store) {

UpdateCaches(&lookup, receiver, name, value);

- } else if (!name->IsCacheable(isolate()) ||

- lookup.IsNormal() ||

+ } else if (lookup.IsNormal() ||

(lookup.IsField() && lookup.CanHoldValue(value))) {

Handle<Code> stub = generic_stub();

set_target(*stub);

« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »