Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Side by Side Diff: src/ic.cc

Issue 329393005: Allow all Names to be fast property names (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1308 matching lines...) Expand 10 before | Expand all | Expand 10 after
1319 // Strict mode doesn't allow setting non-existent global property. 1319 // Strict mode doesn't allow setting non-existent global property.
1320 return ReferenceError("not_defined", name); 1320 return ReferenceError("not_defined", name);
1321 } 1321 }
1322 if (FLAG_use_ic) { 1322 if (FLAG_use_ic) {
1323 if (state() == UNINITIALIZED) { 1323 if (state() == UNINITIALIZED) {
1324 Handle<Code> stub = pre_monomorphic_stub(); 1324 Handle<Code> stub = pre_monomorphic_stub();
1325 set_target(*stub); 1325 set_target(*stub);
1326 TRACE_IC("StoreIC", name); 1326 TRACE_IC("StoreIC", name);
1327 } else if (can_store) { 1327 } else if (can_store) {
1328 UpdateCaches(&lookup, receiver, name, value); 1328 UpdateCaches(&lookup, receiver, name, value);
1329 } else if (!name->IsCacheable(isolate()) || 1329 } else if (lookup.IsNormal() ||
1330 lookup.IsNormal() ||
1331 (lookup.IsField() && lookup.CanHoldValue(value))) { 1330 (lookup.IsField() && lookup.CanHoldValue(value))) {
1332 Handle<Code> stub = generic_stub(); 1331 Handle<Code> stub = generic_stub();
1333 set_target(*stub); 1332 set_target(*stub);
1334 } 1333 }
1335 } 1334 }
1336 1335
1337 // Set the property. 1336 // Set the property.
1338 Handle<Object> result; 1337 Handle<Object> result;
1339 ASSIGN_RETURN_ON_EXCEPTION( 1338 ASSIGN_RETURN_ON_EXCEPTION(
1340 isolate(), 1339 isolate(),
(...skipping 1758 matching lines...) Expand 10 before | Expand all | Expand 10 after
3099 #undef ADDR 3098 #undef ADDR
3100 }; 3099 };
3101 3100
3102 3101
3103 Address IC::AddressFromUtilityId(IC::UtilityId id) { 3102 Address IC::AddressFromUtilityId(IC::UtilityId id) {
3104 return IC_utilities[id]; 3103 return IC_utilities[id];
3105 } 3104 }
3106 3105
3107 3106
3108 } } // namespace v8::internal 3107 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698